Patchwork [2,of,2] monoblue: use padding instead of position for text in footer

login
register
mail settings
Submitter Anton Shestakov
Date July 8, 2015, 4:28 a.m.
Message ID <a04ff088a193f780fca8.1436329731@neuro>
Download mbox | patch
Permalink /patch/9915/
State Accepted
Headers show

Comments

Anton Shestakov - July 8, 2015, 4:28 a.m.
# HG changeset patch
# User Anton Shestakov <av6@dwimlabs.net>
# Date 1436117917 -28800
#      Mon Jul 06 01:38:37 2015 +0800
# Node ID a04ff088a193f780fca84730847a1959b2a99939
# Parent  a3285457998bf5c03425c46609d9d77105bb2037
monoblue: use padding instead of position for text in footer

Some installations alter monoblue style and remove margins from body element
(these margins have that dark gray background) to adapt hgweb instance to an
already existing site design. However, the margins hid a quirk in page footer:
a block of text needlessly popped out of the footer, and when margins were
gone, the whole page got a vertical scroll bar because of that.

Live example: https://hg.prosody.im/prosody-modules/

To remove the potential scroll bar, this block of text now uses left padding,
which doesn't make it overflow the footer, but makes it achieve the otherwise
same result visually.
Matt Mackall - July 8, 2015, 7:35 p.m.
On Wed, 2015-07-08 at 12:28 +0800, Anton Shestakov wrote:
> # HG changeset patch
> # User Anton Shestakov <av6@dwimlabs.net>
> # Date 1436117917 -28800
> #      Mon Jul 06 01:38:37 2015 +0800
> # Node ID a04ff088a193f780fca84730847a1959b2a99939
> # Parent  a3285457998bf5c03425c46609d9d77105bb2037
> monoblue: use padding instead of position for text in footer

These are queued for default, thanks.

Patch

diff --git a/mercurial/templates/static/style-monoblue.css b/mercurial/templates/static/style-monoblue.css
--- a/mercurial/templates/static/style-monoblue.css
+++ b/mercurial/templates/static/style-monoblue.css
@@ -153,7 +153,7 @@  div.page-footer {
 }
   div.page-footer p {
     position: relative;
-    left: 20px;
+    padding-left: 20px;
     bottom: 5px;
     font-size: 1.2em;
   }