From patchwork Wed Feb 13 21:38:47 2013
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [RFC] blackbox: do not translate the log messages
From: Durham Goode <durham@fb.com>
X-Patchwork-Id: 986
Message-Id: <9e42d1429fc278b83adb.1360791527@dev350.prn1.facebook.com>
To: mercurial-devel@selenic.com
Date: Wed, 13 Feb 2013 13:38:47 -0800

# HG changeset patch
# User Durham Goode <durham@fb.com>
# Date 1360788690 28800
#      Wed Feb 13 12:51:30 2013 -0800
# Node ID 9e42d1429fc278b83adb14e039f8fb4093048b0f
# Parent  dcef36a6f4e3f8dfd99987c8867209d40799277b
blackbox: do not translate the log messages

User 'timeless' in irc mentioned that having the blackbox be translated
would result in logs that:

- may be mixed language, if multiple users use the same repo
- are not google searchable (since searching for english gives more results)
- might not be readable by an admin if the employee is using hg in his native
language

And therefore we should log everything in english.

It seems weird to me to produce a log in english when the user chose a different
language. I don't know what mercurial's translation policy is, nor am I familiar
with foreign language use of software in general, so I wanted to throw this out
there for comment before I made the change.

diff --git a/mercurial/dispatch.py b/mercurial/dispatch.py
--- a/mercurial/dispatch.py
+++ b/mercurial/dispatch.py
@@ -747,7 +747,7 @@
         return ret
     finally:
         duration = time.time() - starttime
-        ui.log("commandfinish", _("%s exited %s after %0.2f seconds\n"),
+        ui.log("commandfinish", "%s exited %s after %0.2f seconds\n",
                cmd, ret, duration)
         if repo and repo != req.repo:
             repo.close()
diff --git a/mercurial/hook.py b/mercurial/hook.py
--- a/mercurial/hook.py
+++ b/mercurial/hook.py
@@ -98,7 +98,7 @@
         readablefunc = funcname
         if isinstance(funcname, types.FunctionType):
             readablefunc = funcname.__module__ + "." + funcname.__name__
-        ui.log('pythonhook', _('pythonhook-%s: %s finished in %0.2f seconds\n'),
+        ui.log('pythonhook', 'pythonhook-%s: %s finished in %0.2f seconds\n',
                name, readablefunc, duration)
     if r:
         if throw:
@@ -132,7 +132,7 @@
         r = util.system(cmd, environ=env, cwd=cwd, out=ui.fout)
 
     duration = time.time() - starttime
-    ui.log('exthook', _('exthook-%s: %s finished in %0.2f seconds\n'),
+    ui.log('exthook', 'exthook-%s: %s finished in %0.2f seconds\n',
            name, cmd, duration)
     if r:
         desc, r = util.explainexit(r)
diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -2402,7 +2402,7 @@
 
                     newheads = [h for h in self.heads() if h not in oldheads]
                     self.ui.log("incoming",
-                                _("%s incoming changes - new heads: %s\n"),
+                                "%s incoming changes - new heads: %s\n",
                                 len(added),
                                 ', '.join([hex(c[:6]) for c in newheads]))
                 self._afterlock(runhooks)