Patchwork check-commit: catch both patterns of double empty lines

login
register
mail settings
Submitter Yuya Nishihara
Date June 21, 2015, 8:29 a.m.
Message ID <a7bb8219ee0a80b8f849.1434875384@mimosa>
Download mbox | patch
Permalink /patch/9743/
State Accepted
Headers show

Comments

Yuya Nishihara - June 21, 2015, 8:29 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1434867529 -32400
#      Sun Jun 21 15:18:49 2015 +0900
# Node ID a7bb8219ee0a80b8f849b5c7a2fe1f9227e8e0c7
# Parent  7fdd1782fc4ee9da87d8af13e806dc9055db2c38
check-commit: catch both patterns of double empty lines
Augie Fackler - June 22, 2015, 2:24 p.m.
On Sun, Jun 21, 2015 at 05:29:44PM +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1434867529 -32400
> #      Sun Jun 21 15:18:49 2015 +0900
> # Node ID a7bb8219ee0a80b8f849b5c7a2fe1f9227e8e0c7
> # Parent  7fdd1782fc4ee9da87d8af13e806dc9055db2c38
> check-commit: catch both patterns of double empty lines

queued this, thanks

>
> diff --git a/contrib/check-commit b/contrib/check-commit
> --- a/contrib/check-commit
> +++ b/contrib/check-commit
> @@ -29,6 +29,7 @@ errors = [
>      (r"^# .*\n.*\.\s+$", "don't add trailing period on summary line"),
>      (r"^# .*\n.{78,}", "summary line too long (limit is 78)"),
>      (r"^\+\n \n", "adds double empty line"),
> +    (r"^ \n\+\n", "adds double empty line"),
>      (r"^\+[ \t]+def [a-z]+_[a-z]", "adds a function with foo_bar naming"),
>  ]
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel

Patch

diff --git a/contrib/check-commit b/contrib/check-commit
--- a/contrib/check-commit
+++ b/contrib/check-commit
@@ -29,6 +29,7 @@  errors = [
     (r"^# .*\n.*\.\s+$", "don't add trailing period on summary line"),
     (r"^# .*\n.{78,}", "summary line too long (limit is 78)"),
     (r"^\+\n \n", "adds double empty line"),
+    (r"^ \n\+\n", "adds double empty line"),
     (r"^\+[ \t]+def [a-z]+_[a-z]", "adds a function with foo_bar naming"),
 ]