Patchwork [4,of,4] code-check: warn about line glob match with no glob character (?*/)

login
register
mail settings
Submitter Simon Heimberg
Date Feb. 12, 2013, 11:05 p.m.
Message ID <dca96b2ac9e1f536f69a.1360710333@lapsi.heimberg.home>
Download mbox | patch
Permalink /patch/970/
State Accepted, archived
Headers show

Comments

Simon Heimberg - Feb. 12, 2013, 11:05 p.m.
# HG changeset patch
# User Simon Heimberg <simohe@besonet.ch>
# Date 1350059530 -7200
# Node ID dca96b2ac9e1f536f69a9be658d9f4c72f6c6de0
# Parent  a36b0c19bec9b4d43ab250b091fbddb614d75374
code-check: warn about line glob match with no glob character (?*/)

Patch

diff -r a36b0c19bec9 -r dca96b2ac9e1 contrib/check-code.py
--- a/contrib/check-code.py	Mon Okt 15 23:32:28 2012 +0200
+++ b/contrib/check-code.py	Fre Okt 12 18:32:10 2012 +0200
@@ -105,7 +105,10 @@ 
      "use (glob) to match Windows paths too"),
   ],
   # warnings
-  []
+  [
+    (r'^  [^*?/\n]* \(glob\)$',
+     "warning: glob match with no glob character (?*/)"),
+  ]
 ]
 
 for i in [0, 1]: