Patchwork [2,of,3] contrib: rename revsetbenchmarks.txt to 'base-revsets.txt'

login
register
mail settings
Submitter Pierre-Yves David
Date June 17, 2015, 6:26 p.m.
Message ID <404dbea076a1f602379c.1434565560@marginatus.alto.octopoid.net>
Download mbox | patch
Permalink /patch/9695/
State Accepted
Headers show

Comments

Pierre-Yves David - June 17, 2015, 6:26 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1434512160 25200
#      Tue Jun 16 20:36:00 2015 -0700
# Node ID 404dbea076a1f602379c5b71975f26eadcdd2641
# Parent  8d9c687c069ae920ebc9c823de307e8780a09095
contrib: rename revsetbenchmarks.txt to 'base-revsets.txt'

We rename the file and document its purpose. We'll be introducing another file
gathering revsets useful for benchmark of the predicate themsleves in a coming
changesets.

Patch

diff --git a/contrib/revsetbenchmarks.txt b/contrib/base-revsets.txt
rename from contrib/revsetbenchmarks.txt
rename to contrib/base-revsets.txt
--- a/contrib/revsetbenchmarks.txt
+++ b/contrib/base-revsets.txt
@@ -1,5 +1,22 @@ 
+# Base Revsets to be used with revsetbenchmarks.py script
+#
+# The goal of this file is to gather a limited amount of revsets that allow a
+# good coverage of the internal revsets mechanisms.  Revsets included should not
+# be selected for their individual implementation, but for what they reveal of
+# the internal implementation of smartsets classes (and their interactions).
+#
+# Use and update this file when you change internal implementation of these
+# smartsets classes. Please include a comment explaining what each of your
+# addition is testing. Also check if your changes to the smartset class makes
+# some of the tests inadequate and replace them with a new one testing the same
+# behavior.
+#
+# The current content of this file is currently likely not reaching this goal
+# entirely, feel free, to audit its content and comment on each revset to
+# highlight what internal mechanisms they test.
+
 all()
 draft()
 ::tip
 draft() and ::tip
 ::tip and draft()