Patchwork [5,of,5,V3] help: use 'color' as an example (instead of 'progress')

login
register
mail settings
Submitter Pierre-Yves David
Date June 11, 2015, 7:31 a.m.
Message ID <fe6c29220162f1c0f820.1434007897@marginatus.alto.octopoid.net>
Download mbox | patch
Permalink /patch/9603/
State Accepted
Headers show

Comments

Pierre-Yves David - June 11, 2015, 7:31 a.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1434007566 25200
#      Thu Jun 11 00:26:06 2015 -0700
# Node ID fe6c29220162f1c0f8201295661236d2c749f3e5
# Parent  b22d4a0a933fa1bb8400e3c1c2df1fba5f2f8a7a
help: use 'color' as an example (instead of 'progress')

Progress is not deprecated, using it as an example is suboptimal.
Gilles Moris - June 11, 2015, 7:24 p.m.
Series LGTM, thanks.

Le 11/06/2015 09:31, Pierre-Yves David a écrit :
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@fb.com>
> # Date 1434007566 25200
> #      Thu Jun 11 00:26:06 2015 -0700
> # Node ID fe6c29220162f1c0f8201295661236d2c749f3e5
> # Parent  b22d4a0a933fa1bb8400e3c1c2df1fba5f2f8a7a
> help: use 'color' as an example (instead of 'progress')
>
> Progress is not deprecated, using it as an example is suboptimal.
>
> diff --git a/mercurial/help/config.txt b/mercurial/help/config.txt
> --- a/mercurial/help/config.txt
> +++ b/mercurial/help/config.txt
> @@ -639,12 +639,12 @@ broader scope, prepend its path with ``!
>   or ``foo = !`` when path is not supplied.
>   
>   Example for ``~/.hgrc``::
>   
>     [extensions]
> -  # (the progress extension will get loaded from Mercurial's path)
> -  progress =
> +  # (the color extension will get loaded from Mercurial's path)
> +  color =
>     # (this extension will get loaded from the file specified)
>     myfeature = ~/.hgext/myfeature.py
>   
>   
>   ``format``
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel
Jordi Gutiérrez Hermoso - June 11, 2015, 7:45 p.m.
On Thu, 2015-06-11 at 00:31 -0700, Pierre-Yves David wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@fb.com>
> # Date 1434007566 25200
> #      Thu Jun 11 00:26:06 2015 -0700
> # Node ID fe6c29220162f1c0f8201295661236d2c749f3e5
> # Parent  b22d4a0a933fa1bb8400e3c1c2df1fba5f2f8a7a
> help: use 'color' as an example (instead of 'progress')
> 
> Progress is not deprecated, using it as an example is suboptimal.

You mean, "now deprecated"?
Pierre-Yves David - June 11, 2015, 7:50 p.m.
On 06/11/2015 12:45 PM, Jordi Gutiérrez Hermoso wrote:
> On Thu, 2015-06-11 at 00:31 -0700, Pierre-Yves David wrote:
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david@fb.com>
>> # Date 1434007566 25200
>> #      Thu Jun 11 00:26:06 2015 -0700
>> # Node ID fe6c29220162f1c0f8201295661236d2c749f3e5
>> # Parent  b22d4a0a933fa1bb8400e3c1c2df1fba5f2f8a7a
>> help: use 'color' as an example (instead of 'progress')
>>
>> Progress is not deprecated, using it as an example is suboptimal.
>
> You mean, "now deprecated"?

AS already pointed by Gilles Moris (no idea which on is the first name), 
yes I do.

(congratulation for your level 1 in marmoutese
Martin von Zweigbergk - June 12, 2015, 8:21 p.m.
I've pushed this to the clowncopter. I fixed the "now deprecated" as well
as some other little types on the help texts. Thanks.

On Thu, Jun 11, 2015 at 12:51 PM Pierre-Yves David <
pierre-yves.david@ens-lyon.org> wrote:

>
>
> On 06/11/2015 12:45 PM, Jordi Gutiérrez Hermoso wrote:
> > On Thu, 2015-06-11 at 00:31 -0700, Pierre-Yves David wrote:
> >> # HG changeset patch
> >> # User Pierre-Yves David <pierre-yves.david@fb.com>
> >> # Date 1434007566 25200
> >> #      Thu Jun 11 00:26:06 2015 -0700
> >> # Node ID fe6c29220162f1c0f8201295661236d2c749f3e5
> >> # Parent  b22d4a0a933fa1bb8400e3c1c2df1fba5f2f8a7a
> >> help: use 'color' as an example (instead of 'progress')
> >>
> >> Progress is not deprecated, using it as an example is suboptimal.
> >
> > You mean, "now deprecated"?
>
> AS already pointed by Gilles Moris (no idea which on is the first name),
> yes I do.
>
> (congratulation for your level 1 in marmoutese
>
> --
> Pierre-Yves David
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel
>

Patch

diff --git a/mercurial/help/config.txt b/mercurial/help/config.txt
--- a/mercurial/help/config.txt
+++ b/mercurial/help/config.txt
@@ -639,12 +639,12 @@  broader scope, prepend its path with ``!
 or ``foo = !`` when path is not supplied.
 
 Example for ``~/.hgrc``::
 
   [extensions]
-  # (the progress extension will get loaded from Mercurial's path)
-  progress =
+  # (the color extension will get loaded from Mercurial's path)
+  color =
   # (this extension will get loaded from the file specified)
   myfeature = ~/.hgext/myfeature.py
 
 
 ``format``