Patchwork [1,of,4,V2] progress: display progress bars by default with core Mercurial

login
register
mail settings
Submitter Pierre-Yves David
Date June 10, 2015, 7:02 p.m.
Message ID <f81552058c8b90a5caca.1433962962@marginatus.alto.octopoid.net>
Download mbox | patch
Permalink /patch/9587/
State Superseded
Headers show

Comments

Pierre-Yves David - June 10, 2015, 7:02 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1433724687 25200
#      Sun Jun 07 17:51:27 2015 -0700
# Node ID f81552058c8b90a5caca16aebe7fc2cb6de2d837
# Parent  e26c72a5a9aa4c13b0d57621dcce265f581abdcd
progress: display progress bars by default with core Mercurial

As discussed multiple time during sprint, we should activate proress by
default. Having progress bar sgnificantly improse the user experience.
Gilles Moris - June 11, 2015, 5:45 a.m.
Couple typos:

Le 10/06/2015 21:02, Pierre-Yves David a écrit :
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@fb.com>
> # Date 1433724687 25200
> #      Sun Jun 07 17:51:27 2015 -0700
> # Node ID f81552058c8b90a5caca16aebe7fc2cb6de2d837
> # Parent  e26c72a5a9aa4c13b0d57621dcce265f581abdcd
> progress: display progress bars by default with core Mercurial
>
> As discussed multiple time during sprint, we should activate proress by
proress => progress
> default. Having progress bar sgnificantly improse the user experience.
improse => improve
>
> diff --git a/mercurial/ui.py b/mercurial/ui.py
> --- a/mercurial/ui.py
> +++ b/mercurial/ui.py
> @@ -890,11 +890,11 @@ class ui(object):
>   
>       @util.propertycache
>       def _progbar(self):
>           """setup the progbar singleton to the ui object"""
>           if (self.quiet or self.debugflag
> -                or self.configbool('progress', 'disable', True)
> +                or self.configbool('progress', 'disable', False)
>                   or not progress.shouldprint(self)):
>               return None
>           return getprogbar(self)
>   
>       def _progclear(self):
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel

Patch

diff --git a/mercurial/ui.py b/mercurial/ui.py
--- a/mercurial/ui.py
+++ b/mercurial/ui.py
@@ -890,11 +890,11 @@  class ui(object):
 
     @util.propertycache
     def _progbar(self):
         """setup the progbar singleton to the ui object"""
         if (self.quiet or self.debugflag
-                or self.configbool('progress', 'disable', True)
+                or self.configbool('progress', 'disable', False)
                 or not progress.shouldprint(self)):
             return None
         return getprogbar(self)
 
     def _progclear(self):