Patchwork [1,of,8] bundle2: add an informative comment to the capability dict

login
register
mail settings
Submitter Pierre-Yves David
Date May 29, 2015, 9:21 p.m.
Message ID <5a5b7046d00e353caa45.1432934514@waste.org>
Download mbox | patch
Permalink /patch/9388/
State Accepted
Headers show

Comments

Pierre-Yves David - May 29, 2015, 9:21 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1432832422 25200
#      Thu May 28 10:00:22 2015 -0700
# Node ID 5a5b7046d00e353caa45783e409760907691c04b
# Parent  a4acf019dd5b72e91a1b1321d80d298033be8111
bundle2: add an informative comment to the capability dict

It is fairly easy to get confused by capabilities "missing" from this dict. We
make it clear the dict is not the whole story.

Patch

diff --git a/mercurial/bundle2.py b/mercurial/bundle2.py
--- a/mercurial/bundle2.py
+++ b/mercurial/bundle2.py
@@ -1019,6 +1019,8 @@ 
                 raise util.Abort(_('Seek failed\n'))
             self._pos = newpos
 
+# These are only the static capabilities.
+# Check the 'getrepocaps' function for the rest.
 capabilities = {'HG20': (),
                 'listkeys': (),
                 'pushkey': (),