Patchwork [6,of,7] dirstate: use match.prefix() instead of 'not match.anypats()'

login
register
mail settings
Submitter Martin von Zweigbergk
Date May 21, 2015, 9:32 p.m.
Message ID <57b2ad183735e615d30f.1432243953@waste.org>
Download mbox | patch
Permalink /patch/9226/
State Accepted
Delegated to: Augie Fackler
Headers show

Comments

Martin von Zweigbergk - May 21, 2015, 9:32 p.m.
# HG changeset patch
# User Martin von Zweigbergk <martinvonz@google.com>
# Date 1432057240 25200
#      Tue May 19 10:40:40 2015 -0700
# Node ID 57b2ad183735e615d30fce568c3612c83fae4f42
# Parent  769c0f5320b6eed726b54cad7623ff078ae80677
dirstate: use match.prefix() instead of 'not match.anypats()'

It seems clearer to check for what it is than what it isn't.

Patch

diff --git a/mercurial/dirstate.py b/mercurial/dirstate.py
--- a/mercurial/dirstate.py
+++ b/mercurial/dirstate.py
@@ -985,7 +985,7 @@ 
             # fast path -- filter the other way around, since typically files is
             # much smaller than dmap
             return [f for f in files if f in dmap]
-        if not match.anypats() and all(fn in dmap for fn in files):
+        if match.prefix() and all(fn in dmap for fn in files):
             # fast path -- all the values are known to be files, so just return
             # that
             return list(files)