Patchwork [1,of,2] revset: drop docstring from internal _notpublic() function

login
register
mail settings
Submitter Yuya Nishihara
Date May 19, 2015, 2:58 p.m.
Message ID <aab49310051b2c7404e1.1432047494@mimosa>
Download mbox | patch
Permalink /patch/9172/
State Accepted
Headers show

Comments

Yuya Nishihara - May 19, 2015, 2:58 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1432045585 -32400
#      Tue May 19 23:26:25 2015 +0900
# Node ID aab49310051b2c7404e1c053779b52fe01aaa3ca
# Parent  a39c35e8e559e238f311c647679e8de3b91748c6
revset: drop docstring from internal _notpublic() function

It shouldn't be listed in "hg help revset".
Pierre-Yves David - May 19, 2015, 3:26 p.m.
On 05/19/2015 09:58 AM, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1432045585 -32400
> #      Tue May 19 23:26:25 2015 +0900
> # Node ID aab49310051b2c7404e1c053779b52fe01aaa3ca
> # Parent  a39c35e8e559e238f311c647679e8de3b91748c6
> revset: drop docstring from internal _notpublic() function
>
> It shouldn't be listed in "hg help revset".

What about we turn that into a # comments?
Yuya Nishihara - May 19, 2015, 10:57 p.m.
On Tue, 19 May 2015 10:26:54 -0500, Pierre-Yves David wrote:
> On 05/19/2015 09:58 AM, Yuya Nishihara wrote:
> > # HG changeset patch
> > # User Yuya Nishihara <yuya@tcha.org>
> > # Date 1432045585 -32400
> > #      Tue May 19 23:26:25 2015 +0900
> > # Node ID aab49310051b2c7404e1c053779b52fe01aaa3ca
> > # Parent  a39c35e8e559e238f311c647679e8de3b91748c6
> > revset: drop docstring from internal _notpublic() function
> >
> > It shouldn't be listed in "hg help revset".
> 
> What about we turn that into a # comments?

Possible, but I didn't think it had valuable information.
Pierre-Yves David - May 20, 2015, 2:38 a.m.
On 05/19/2015 05:57 PM, Yuya Nishihara wrote:
> On Tue, 19 May 2015 10:26:54 -0500, Pierre-Yves David wrote:
>> On 05/19/2015 09:58 AM, Yuya Nishihara wrote:
>>> # HG changeset patch
>>> # User Yuya Nishihara <yuya@tcha.org>
>>> # Date 1432045585 -32400
>>> #      Tue May 19 23:26:25 2015 +0900
>>> # Node ID aab49310051b2c7404e1c053779b52fe01aaa3ca
>>> # Parent  a39c35e8e559e238f311c647679e8de3b91748c6
>>> revset: drop docstring from internal _notpublic() function
>>>
>>> It shouldn't be listed in "hg help revset".
>>
>> What about we turn that into a # comments?
>
> Possible, but I didn't think it had valuable information.

okay, these are pushed to the clowncopter.

Patch

diff --git a/mercurial/revset.py b/mercurial/revset.py
--- a/mercurial/revset.py
+++ b/mercurial/revset.py
@@ -1478,9 +1478,8 @@  def present(repo, subset, x):
     except error.RepoLookupError:
         return baseset()
 
+# for internal use
 def _notpublic(repo, subset, x):
-    """``_notpublic()``
-    Changeset not in public phase."""
     # i18n: "public" is a keyword
     getargs(x, 0, 0, _("_notpublic takes no arguments"))
     if repo._phasecache._phasesets: