Patchwork [4,of,4,V2] tests: check import cycles in hgext/**.py, too

login
register
mail settings
Submitter Katsunori FUJIWARA
Date May 15, 2015, 2:13 p.m.
Message ID <19dec58e4b96aac5a9f6.1431699228@juju>
Download mbox | patch
Permalink /patch/9097/
State Accepted
Commit f8b602fd4643f86336c373f12d0e9d012a617602
Delegated to: Augie Fackler
Headers show

Comments

Katsunori FUJIWARA - May 15, 2015, 2:13 p.m.
# HG changeset patch
# User FUJIWARA Katsunori <foozy@lares.dti.ne.jp>
# Date 1431699038 -32400
#      Fri May 15 23:10:38 2015 +0900
# Node ID 19dec58e4b96aac5a9f60f21d452de4169531d69
# Parent  0403363ab33ce62c84ab1fc004da081357516362
tests: check import cycles in hgext/**.py, too

It is important to realize existing cycles in hgext/**.py.

Patch

diff --git a/tests/test-module-imports.t b/tests/test-module-imports.t
--- a/tests/test-module-imports.t
+++ b/tests/test-module-imports.t
@@ -20,7 +20,7 @@  here that we should still endeavor to fi
 hidden by deduplication algorithm in the cycle detector, so fixing
 these may expose other cycles.
 
-  $ hg locate 'mercurial/**.py' | sed 's-\\-/-g' | python "$import_checker" -
+  $ hg locate 'mercurial/**.py' 'hgext/**.py' | sed 's-\\-/-g' | python "$import_checker" -
   mercurial/dispatch.py mixed imports
      stdlib:    commands
      relative:  error, extensions, fancyopts, hg, hook, util
@@ -37,4 +37,5 @@  these may expose other cycles.
      stdlib:    formatter
      relative:  config, error, scmutil, util
   Import cycle: mercurial.cmdutil -> mercurial.context -> mercurial.subrepo -> mercurial.cmdutil
+  Import cycle: hgext.largefiles.basestore -> hgext.largefiles.localstore -> hgext.largefiles.basestore
   Import cycle: mercurial.commands -> mercurial.commandserver -> mercurial.dispatch -> mercurial.commands