Patchwork [3,of,3] setup: integrate osutil C extension into extmodules initialization

login
register
mail settings
Submitter Adrian Buehlmann
Date May 14, 2015, 9:11 a.m.
Message ID <23569147cb815cbf27dc.1431594713@kork>
Download mbox | patch
Permalink /patch/9071/
State Accepted
Headers show

Comments

Adrian Buehlmann - May 14, 2015, 9:11 a.m.
# HG changeset patch
# User Adrian Buehlmann <adrian@cadifra.com>
# Date 1431594276 -7200
# Node ID 23569147cb815cbf27dca415289bc9cdc254583f
# Parent  77937476f8856a189d98a894efc7d8a51ce2d651
setup: integrate osutil C extension into extmodules initialization
Pierre-Yves David - May 14, 2015, 6:34 p.m.
On 05/14/2015 02:11 AM, Adrian Buehlmann wrote:
> # HG changeset patch
> # User Adrian Buehlmann <adrian@cadifra.com>
> # Date 1431594276 -7200
> # Node ID 23569147cb815cbf27dca415289bc9cdc254583f
> # Parent  77937476f8856a189d98a894efc7d8a51ce2d651
> setup: integrate osutil C extension into extmodules initialization

theses looks okay to me.

I've pushed them to the clowncopter. Thanks

Patch

diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -503,12 +503,11 @@ 
                                     'mercurial/parsers.c',
                                     'mercurial/pathencode.c'],
               depends=common_depends),
+    Extension('mercurial.osutil', ['mercurial/osutil.c'],
+              extra_link_args=osutil_ldflags,
+              depends=common_depends),
     ]
 
-extmodules.append(Extension('mercurial.osutil', ['mercurial/osutil.c'],
-                            extra_link_args=osutil_ldflags,
-                            depends=common_depends))
-
 try:
     from distutils import cygwinccompiler