Patchwork [3,of,5,evolve-ext] evolve: add new line after error message

login
register
mail settings
Submitter Laurent Charignon
Date May 13, 2015, 5:04 p.m.
Message ID <96db44ca62d46ac9b570.1431536661@lcharignon-mbp.local>
Download mbox | patch
Permalink /patch/9054/
State Changes Requested
Headers show

Comments

Laurent Charignon - May 13, 2015, 5:04 p.m.
# HG changeset patch
# User Laurent Charignon <lcharignon@fb.com>
# Date 1431535594 25200
#      Wed May 13 09:46:34 2015 -0700
# Node ID 96db44ca62d46ac9b57042885e40adb8c1fd9e4e
# Parent  b2e0ca2d6ab8e8399feb6138b6afc1beb9eadc52
evolve: add new line after error message

The new line was missing in a previous patch.
Pierre-Yves David - May 14, 2015, 12:14 a.m.
On 05/13/2015 10:04 AM, Laurent Charignon wrote:
> # HG changeset patch
> # User Laurent Charignon <lcharignon@fb.com>
> # Date 1431535594 25200
> #      Wed May 13 09:46:34 2015 -0700
> # Node ID 96db44ca62d46ac9b57042885e40adb8c1fd9e4e
> # Parent  b2e0ca2d6ab8e8399feb6138b6afc1beb9eadc52
> evolve: add new line after error message
>
> The new line was missing in a previous patch.
>
> diff --git a/hgext/evolve.py b/hgext/evolve.py
> --- a/hgext/evolve.py
> +++ b/hgext/evolve.py
> @@ -1307,7 +1307,7 @@
>           troubled = repo.revs('troubled()')
>           _revs = revs & troubled
>           if not _revs:
> -            ui.write_err("No troubled changes in the specified revset")
> +            ui.write_err("No troubled changes in the specified revset\n")
>           else:
>               for rev in _revs:
>                   _solveone(ui, repo, repo[rev], dryrunopt, confirmopt,

I missed that working the first time. Can we get ride of 'revset' and 
use revisions instead?
Laurent Charignon - May 14, 2015, 12:27 a.m.
On 5/13/15, 5:14 PM, "Pierre-Yves David" <pierre-yves.david@ens-lyon.org>
wrote:

>
>
>On 05/13/2015 10:04 AM, Laurent Charignon wrote:
>> # HG changeset patch
>> # User Laurent Charignon <lcharignon@fb.com>
>> # Date 1431535594 25200
>> #      Wed May 13 09:46:34 2015 -0700
>> # Node ID 96db44ca62d46ac9b57042885e40adb8c1fd9e4e
>> # Parent  b2e0ca2d6ab8e8399feb6138b6afc1beb9eadc52
>> evolve: add new line after error message
>>
>> The new line was missing in a previous patch.
>>
>> diff --git a/hgext/evolve.py b/hgext/evolve.py
>> --- a/hgext/evolve.py
>> +++ b/hgext/evolve.py
>> @@ -1307,7 +1307,7 @@
>>           troubled = repo.revs('troubled()')
>>           _revs = revs & troubled
>>           if not _revs:
>> -            ui.write_err("No troubled changes in the specified revset")
>> +            ui.write_err("No troubled changes in the specified
>>revset\n")
>>           else:
>>               for rev in _revs:
>>                   _solveone(ui, repo, repo[rev], dryrunopt, confirmopt,
>
>I missed that working the first time. Can we get ride of 'revset' and
>use revisions instead?

Ok, I will send that in the V2.
>
>
>-- 
>Pierre-Yves David

Patch

diff --git a/hgext/evolve.py b/hgext/evolve.py
--- a/hgext/evolve.py
+++ b/hgext/evolve.py
@@ -1307,7 +1307,7 @@ 
         troubled = repo.revs('troubled()')
         _revs = revs & troubled
         if not _revs:
-            ui.write_err("No troubled changes in the specified revset")
+            ui.write_err("No troubled changes in the specified revset\n")
         else:
             for rev in _revs:
                 _solveone(ui, repo, repo[rev], dryrunopt, confirmopt,