Patchwork [STABLE] test-run-test: unset run-test specific environment variables

login
register
mail settings
Submitter Pierre-Yves David
Date May 8, 2015, 6:42 p.m.
Message ID <2fe1e548c0e0a69836f7.1431110531@marginatus.alto.octopoid.net>
Download mbox | patch
Permalink /patch/8978/
State Accepted
Delegated to: Augie Fackler
Headers show

Comments

Pierre-Yves David - May 8, 2015, 6:42 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1431109944 25200
#      Fri May 08 11:32:24 2015 -0700
# Branch stable
# Node ID 2fe1e548c0e0a69836f779e2facff768b228c64b
# Parent  169d2470d283f19f7c94112dc1eff1d355f29f40
test-run-test: unset run-test specific environment variables

Otherwise variable set for the real test run interfere with the test runner
tests.
Sean Farley - May 8, 2015, 6:47 p.m.
Pierre-Yves David <pierre-yves.david@ens-lyon.org> writes:

> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@fb.com>
> # Date 1431109944 25200
> #      Fri May 08 11:32:24 2015 -0700
> # Branch stable
> # Node ID 2fe1e548c0e0a69836f779e2facff768b228c64b
> # Parent  169d2470d283f19f7c94112dc1eff1d355f29f40
> test-run-test: unset run-test specific environment variables
>
> Otherwise variable set for the real test run interfere with the test runner
> tests.
>
> diff --git a/tests/test-run-tests.t b/tests/test-run-tests.t
> --- a/tests/test-run-tests.t
> +++ b/tests/test-run-tests.t
> @@ -1,7 +1,14 @@
>  This file tests the behavior of run-tests.py itself.
>  
> +Avoid interferences from  actual test env:

Looks like an extra space got accidentally placed before 'actual' (minor
nit, feel free to fix in-flight).
Martin von Zweigbergk - May 8, 2015, 9:49 p.m.
On Fri, May 8, 2015 at 11:48 AM Sean Farley <sean@farley.io> wrote:

>
> Pierre-Yves David <pierre-yves.david@ens-lyon.org> writes:
>
> > # HG changeset patch
> > # User Pierre-Yves David <pierre-yves.david@fb.com>
> > # Date 1431109944 25200
> > #      Fri May 08 11:32:24 2015 -0700
> > # Branch stable
> > # Node ID 2fe1e548c0e0a69836f779e2facff768b228c64b
> > # Parent  169d2470d283f19f7c94112dc1eff1d355f29f40
> > test-run-test: unset run-test specific environment variables
> >
> > Otherwise variable set for the real test run interfere with the test
> runner
> > tests.
> >
> > diff --git a/tests/test-run-tests.t b/tests/test-run-tests.t
> > --- a/tests/test-run-tests.t
> > +++ b/tests/test-run-tests.t
> > @@ -1,7 +1,14 @@
> >  This file tests the behavior of run-tests.py itself.
> >
> > +Avoid interferences from  actual test env:
>
> Looks like an extra space got accidentally placed before 'actual' (minor
> nit, feel free to fix in-flight).
>

Done. I also dropped the "s" from "interferences". Pushed to clowncopter.


> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>

Patch

diff --git a/tests/test-run-tests.t b/tests/test-run-tests.t
--- a/tests/test-run-tests.t
+++ b/tests/test-run-tests.t
@@ -1,7 +1,14 @@ 
 This file tests the behavior of run-tests.py itself.
 
+Avoid interferences from  actual test env:
+
+  $ unset HGTEST_JOBS
+  $ unset HGTEST_TIMEOUT
+  $ unset HGTEST_PORT
+  $ unset HGTEST_SHELL
+
 Smoke test
 ============
 
   $ $TESTDIR/run-tests.py $HGTEST_RUN_TESTS_PURE