Patchwork [4,of,4,evolve-ext] evolve: improve the help message of --rev

login
register
mail settings
Submitter Laurent Charignon
Date May 6, 2015, 1:22 a.m.
Message ID <c182c649eae81e38a645.1430875373@lcharignon-mbp.dhcp.thefacebook.com>
Download mbox | patch
Permalink /patch/8927/
State Accepted
Headers show

Comments

Laurent Charignon - May 6, 2015, 1:22 a.m.
# HG changeset patch
# User Laurent Charignon <lcharignon@fb.com>
# Date 1430875240 25200
#      Tue May 05 18:20:40 2015 -0700
# Node ID c182c649eae81e38a64574329ecc904ff169542f
# Parent  dee3756a1deb516c63a961ed8d2d438bd85a0baa
evolve: improve the help message of --rev

User's are not exposed to the notion of revset, this patch makes the help
message more intelligible.
Pierre-Yves David - May 6, 2015, 5:28 p.m.
On 05/05/2015 06:22 PM, Laurent Charignon wrote:
> # HG changeset patch
> # User Laurent Charignon <lcharignon@fb.com>
> # Date 1430875240 25200
> #      Tue May 05 18:20:40 2015 -0700
> # Node ID c182c649eae81e38a64574329ecc904ff169542f
> # Parent  dee3756a1deb516c63a961ed8d2d438bd85a0baa
> evolve: improve the help message of --rev

I took this one, thanks. (should have been patch 1)

reviewing this I also spotted that you are using '' as default value. 
this meaning that only single --rev option can be passed. For commands 
that can affect multiple revision, we use [] the default value, that 
lets the user specify multiple --rev options. The returned option is 
then a list.

Patch

diff --git a/hgext/evolve.py b/hgext/evolve.py
--- a/hgext/evolve.py
+++ b/hgext/evolve.py
@@ -1230,7 +1230,7 @@ 
      ('', 'confirm', False,
         'ask for confirmation before performing the action'),
     ('A', 'any', False, 'also consider troubled changesets unrelated to current working directory'),
-    ('r', 'rev', '', 'revset to find troubles in'),
+    ('r', 'rev', '', 'solves troubles of these revisions'),
     ('a', 'all', False, 'evolve all troubled changesets in the repo '
                         '(implies any)'),
     ('c', 'continue', False, 'continue an interrupted evolution'),