Patchwork [3,of,3] revset: drop factory that promotes spanset to fullreposet

login
register
mail settings
Submitter Pierre-Yves David
Date May 5, 2015, 12:19 a.m.
Message ID <55480C97.8040904@ens-lyon.org>
Download mbox | patch
Permalink /patch/8885/
State Changes Requested
Headers show

Comments

Pierre-Yves David - May 5, 2015, 12:19 a.m.
On 02/10/2015 07:50 AM, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1420728195 -32400
> #      Thu Jan 08 23:43:15 2015 +0900
> # Node ID 9962a866325681d8e4523ea30edd3e2ed8343f98
> # Parent  f04a70f7f3a11b5c66dc739cdf6bcf57d59183ff
> revset: drop factory that promotes spanset to fullreposet

This overlooked the 'all()' revset as a place were spanset was used 
(making combinaison with involving all() less efficients as they 
should). We cannot just fix 'all()' to used 'fullreposet' because 
fullreposet is now doing working copy magic too. This lead to these two 
test failure when tried. Yuya, can I get you to look at this?


ERROR: test-revset.t output changed
!.
Failed test-glog.t: output changed
Failed test-revset.t: output changed

Patch

--- /home/marmoute/mercurial-testing/tests/test-glog.t
+++ /home/marmoute/mercurial-testing/tests/test-glog.t.err
@@ -2370,9 +2370,9 @@ 
    $ hg log -G -r 'all()' | tail -6
    |
    o  changeset:   0:f8035bb17114
-     user:        test
-     date:        Thu Jan 01 00:00:00 1970 +0000
-     summary:     add a
-
+  |  user:        test
+  |  date:        Thu Jan 01 00:00:00 1970 +0000
+  |  summary:     add a
+  |

    $ cd ..

ERROR: test-glog.t output changed
!
--- /home/marmoute/mercurial-testing/tests/test-revset.t
+++ /home/marmoute/mercurial-testing/tests/test-revset.t.err
@@ -601,8 +601,8 @@ 
    $ log 'min(null:)'
    -1
    $ log 'tip:null and all()' | tail -2
-  1
-  0
+  0
+  -1

  Test working-directory revision
    $ hg debugrevspec 'wdir()'