Patchwork [1,of,2] shelve: refactor allowables to specify sets of valid operations

login
register
mail settings
Submitter Tony Tung
Date April 22, 2015, 6:31 p.m.
Message ID <0908f943058e2c1a07ed.1429727484@andromeda.dhcp.thefacebook.com>
Download mbox | patch
Permalink /patch/8764/
State Superseded
Commit ce00b2e96d09134a821d5edd9dcce698fd150398
Headers show

Comments

Tony Tung - April 22, 2015, 6:31 p.m.
# HG changeset patch
# User Tony Tung <tonytung@fb.com>
# Date 1429042987 14400
#      Tue Apr 14 16:23:07 2015 -0400
# Node ID 0908f943058e2c1a07ed6f542f01ea74f65b9dd4
# Parent  2ee10789d66b9ca500a7bfb1b3e031e04cdc4fb7
shelve: refactor allowables to specify sets of valid operations

This allows us to have --patch and --stat as standalone operations that
don't require --list, as well as pairing them with --list.

Patch

diff --git a/hgext/shelve.py b/hgext/shelve.py
--- a/hgext/shelve.py
+++ b/hgext/shelve.py
@@ -692,21 +692,21 @@ 
     cmdutil.checkunfinished(repo)
 
     allowables = [
-        ('addremove', 'create'), # 'create' is pseudo action
-        ('cleanup', 'cleanup'),
-#       ('date', 'create'), # ignored for passing '--date "0 0"' in tests
-        ('delete', 'delete'),
-        ('edit', 'create'),
-        ('list', 'list'),
-        ('message', 'create'),
-        ('name', 'create'),
-        ('patch', 'list'),
-        ('stat', 'list'),
+        ('addremove', set(['create'])), # 'create' is pseudo action
+        ('cleanup', set(['cleanup'])),
+#       ('date', set(['create'])), # ignored for passing '--date "0 0"' in tests
+        ('delete', set(['delete'])),
+        ('edit', set(['create'])),
+        ('list', set(['list'])),
+        ('message', set(['create'])),
+        ('name', set(['create'])),
+        ('patch', set(['list'])),
+        ('stat', set(['list'])),
     ]
     def checkopt(opt):
         if opts[opt]:
             for i, allowable in allowables:
-                if opts[i] and opt != allowable:
+                if opts[i] and opt not in allowable:
                     raise util.Abort(_("options '--%s' and '--%s' may not be "
                                        "used together") % (opt, i))
             return True