Patchwork [5,of,6,V2] ui: add color extension to progressive mode

login
register
mail settings
Submitter Mathias De Maré
Date April 7, 2015, 7 p.m.
Message ID <431cc24028deada0e3bb.1428433251@mathias-Latitude-E6540>
Download mbox | patch
Permalink /patch/8547/
State Changes Requested
Headers show

Comments

Mathias De Maré - April 7, 2015, 7 p.m.
# HG changeset patch
# User Mathias De Maré <mathias.demare@gmail.com>
# Date 1427229798 -3600
#      Tue Mar 24 21:43:18 2015 +0100
# Node ID 431cc24028deada0e3bbc55ff3dee7d962caa922
# Parent  44f6145dde0d844a019c968a6bc5eeddadec533e
ui: add color extension to progressive mode
Matt Mackall - April 8, 2015, 7:40 p.m.
On Tue, 2015-04-07 at 21:00 +0200, mathias.demare@gmail.com wrote:
> # HG changeset patch
> # User Mathias De Maré <mathias.demare@gmail.com>
> # Date 1427229798 -3600
> #      Tue Mar 24 21:43:18 2015 +0100
> # Node ID 431cc24028deada0e3bbc55ff3dee7d962caa922
> # Parent  44f6145dde0d844a019c968a6bc5eeddadec533e
> ui: add color extension to progressive mode

If we want to go this way, we probably want to pull the color extension
fully into core first so that it's only a command-line switch away.

BTW, the number one thing _I_ want to see in progressive (and one of the
few reasons I'm entertaining the idea) is removal of the 'tip'
pseudo-tag.
Mathias De Maré - April 10, 2015, 5:26 p.m.
On Wed, Apr 8, 2015 at 9:40 PM, Matt Mackall <mpm@selenic.com> wrote:

> On Tue, 2015-04-07 at 21:00 +0200, mathias.demare@gmail.com wrote:
> > # HG changeset patch
> > # User Mathias De Maré <mathias.demare@gmail.com>
> > # Date 1427229798 -3600
> > #      Tue Mar 24 21:43:18 2015 +0100
> > # Node ID 431cc24028deada0e3bbc55ff3dee7d962caa922
> > # Parent  44f6145dde0d844a019c968a6bc5eeddadec533e
> > ui: add color extension to progressive mode
>
> If we want to go this way, we probably want to pull the color extension
> fully into core first so that it's only a command-line switch away.
>
What is the usual approach for this? Doing a combined check for either the
switch or the extensions.color selection?

>
> BTW, the number one thing _I_ want to see in progressive (and one of the
> few reasons I'm entertaining the idea) is removal of the 'tip'
> pseudo-tag.
>
That's still in progress, not quite there yet. I'd like to fix that as well
though.

In general, I'll need to see if I can do another submission of this patch
series in the next few days, it may have to wait for the next release...

Greetings,
Mathias

>
> --
> Mathematics is the supreme nostalgia of our time.
>
>
>
Augie Fackler - April 10, 2015, 6:13 p.m.
On Fri, Apr 10, 2015 at 07:26:59PM +0200, Mathias De Maré wrote:
> On Wed, Apr 8, 2015 at 9:40 PM, Matt Mackall <mpm@selenic.com> wrote:
>
> > On Tue, 2015-04-07 at 21:00 +0200, mathias.demare@gmail.com wrote:
> > > # HG changeset patch
> > > # User Mathias De Maré <mathias.demare@gmail.com>
> > > # Date 1427229798 -3600
> > > #      Tue Mar 24 21:43:18 2015 +0100
> > > # Node ID 431cc24028deada0e3bbc55ff3dee7d962caa922
> > > # Parent  44f6145dde0d844a019c968a6bc5eeddadec533e
> > > ui: add color extension to progressive mode
>
[...]

> In general, I'll need to see if I can do another submission of this patch
> series in the next few days, it may have to wait for the next release...

I'm planning to do some bikeshedding around ui.progressive at the sprint.


>
> Greetings,
> Mathias
>
> >
> > --
> > Mathematics is the supreme nostalgia of our time.
> >
> >
> >

> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
Matt Mackall - April 10, 2015, 6:35 p.m.
On Fri, 2015-04-10 at 19:26 +0200, Mathias De Maré wrote:
> On Wed, Apr 8, 2015 at 9:40 PM, Matt Mackall <mpm@selenic.com> wrote:
> 
> > On Tue, 2015-04-07 at 21:00 +0200, mathias.demare@gmail.com wrote:
> > > # HG changeset patch
> > > # User Mathias De Maré <mathias.demare@gmail.com>
> > > # Date 1427229798 -3600
> > > #      Tue Mar 24 21:43:18 2015 +0100
> > > # Node ID 431cc24028deada0e3bbc55ff3dee7d962caa922
> > > # Parent  44f6145dde0d844a019c968a6bc5eeddadec533e
> > > ui: add color extension to progressive mode
> >
> > If we want to go this way, we probably want to pull the color extension
> > fully into core first so that it's only a command-line switch away.
> >
> What is the usual approach for this? Doing a combined check for either the
> switch or the extensions.color selection?

Move the bulk of the code into core, including the global options,
leaving behind a stub extension that sets the default to on.

> > BTW, the number one thing _I_ want to see in progressive (and one of the
> > few reasons I'm entertaining the idea) is removal of the 'tip'
> > pseudo-tag.
> >
> That's still in progress, not quite there yet. I'd like to fix that as well
> though.
> 
> In general, I'll need to see if I can do another submission of this patch
> series in the next few days, it may have to wait for the next release...

Almost certainly, as I expect to be overwhelmed shortly.

Patch

diff -r 44f6145dde0d -r 431cc24028de mercurial/ui.py
--- a/mercurial/ui.py	Tue Mar 24 21:41:39 2015 +0100
+++ b/mercurial/ui.py	Tue Mar 24 21:43:18 2015 +0100
@@ -485,6 +485,8 @@ 
 
         if not self.hasconfig('ui', 'statuscopies'):
             self.setconfig('ui', 'statuscopies', 'True')
+        if not self.hasconfig('extensions', 'color'):
+            self.setconfig('extensions', 'color', '')
 
     def plain(self, feature=None):
         '''is plain mode active?