Patchwork [1,of,3] parsers: remove unused dependency on util

login
register
mail settings
Submitter Drew Gottlieb
Date April 6, 2015, 10:48 p.m.
Message ID <51c4efb8fb03e7cfbbbb.1428360513@waste.org>
Download mbox | patch
Permalink /patch/8514/
State Accepted
Headers show

Comments

Drew Gottlieb - April 6, 2015, 10:48 p.m.
# HG changeset patch
# User Drew Gottlieb <drgott@google.com>
# Date 1428353976 25200
#      Mon Apr 06 13:59:36 2015 -0700
# Node ID 51c4efb8fb03e7cfbbbbca87dac96aa43dc4f509
# Parent  b2fb1403994e033584aed8a487ab162a9d75fa80
parsers: remove unused dependency on util

Parsers.py had a reference to util.sha1 which was unused. This commit removes
this reference as well as the unused import of util to simplify the dependency
graph. This is important for the next commit which actually relocates part
of a module to eliminate a cycle.

Patch

diff --git a/mercurial/pure/parsers.py b/mercurial/pure/parsers.py
--- a/mercurial/pure/parsers.py
+++ b/mercurial/pure/parsers.py
@@ -6,14 +6,12 @@ 
 # GNU General Public License version 2 or any later version.
 
 from mercurial.node import nullid
-from mercurial import util
 import struct, zlib, cStringIO
 
 _pack = struct.pack
 _unpack = struct.unpack
 _compress = zlib.compress
 _decompress = zlib.decompress
-_sha = util.sha1
 
 # Some code below makes tuples directly because it's more convenient. However,
 # code outside this module should always use dirstatetuple.