Patchwork [2,of,4,foldmap-in-C] parsers: make _asciilower a generic _asciitransform function

login
register
mail settings
Submitter Siddharth Agarwal
Date April 1, 2015, 5:28 p.m.
Message ID <c9e4902b765594734dee.1427909285@devbig136.prn2.facebook.com>
Download mbox | patch
Permalink /patch/8417/
State Superseded
Commit fe173106e7fea7f09bdb9a0093fbb06318a6306c
Headers show

Comments

Siddharth Agarwal - April 1, 2015, 5:28 p.m.
# HG changeset patch
# User Siddharth Agarwal <sid0@fb.com>
# Date 1427822897 25200
#      Tue Mar 31 10:28:17 2015 -0700
# Node ID c9e4902b765594734dee25a4070baa646051ed59
# Parent  719010b9a74187eb3139b4e57562ecefde288cc4
parsers: make _asciilower a generic _asciitransform function

We can now pass in whatever table we like. For example, an upcoming patch will
introduce asciiupper.

Patch

diff --git a/mercurial/parsers.c b/mercurial/parsers.c
--- a/mercurial/parsers.c
+++ b/mercurial/parsers.c
@@ -93,7 +93,8 @@ 
 	return ret;
 }
 
-static inline PyObject *_asciilower(PyObject *str_obj)
+static inline PyObject *_asciitransform(PyObject *str_obj,
+					const char table[128])
 {
 	char *str, *newstr;
 	Py_ssize_t i, len;
@@ -119,7 +120,7 @@ 
 			Py_XDECREF(err);
 			goto quit;
 		}
-		newstr[i] = lowertable[(unsigned char)c];
+		newstr[i] = table[(unsigned char)c];
 	}
 
 	ret = newobj;
@@ -134,7 +135,7 @@ 
 	PyObject *str_obj;
 	if (!PyArg_ParseTuple(args, "O!:asciilower", &PyBytes_Type, &str_obj))
 		return NULL;
-	return _asciilower(str_obj);
+	return _asciitransform(str_obj, lowertable);
 }
 
 /*