Patchwork [6,of,8] ui: add color and progress extensions to progressive mode

login
register
mail settings
Submitter Mathias De Maré
Date March 28, 2015, 10:51 a.m.
Message ID <c5c5e11ea7b6c669b22e.1427539866@waste.org>
Download mbox | patch
Permalink /patch/8327/
State Changes Requested
Headers show

Comments

Mathias De Maré - March 28, 2015, 10:51 a.m.
# HG changeset patch
# User Mathias De Maré <mathias.demare@gmail.com>
# Date 1427229798 -3600
#      Tue Mar 24 21:43:18 2015 +0100
# Node ID c5c5e11ea7b6c669b22eee5c94f98e9c11dc01df
# Parent  d8d2248056c411e564fed884887b481bf7abc28a
ui: add color and progress extensions to progressive mode
Matt Mackall - March 31, 2015, 11:15 a.m.
On Sat, 2015-03-28 at 05:51 -0500, Mathias De Maré wrote:
> # HG changeset patch
> # User Mathias De Maré <mathias.demare@gmail.com>
> # Date 1427229798 -3600
> #      Tue Mar 24 21:43:18 2015 +0100
> # Node ID c5c5e11ea7b6c669b22eee5c94f98e9c11dc01df
> # Parent  d8d2248056c411e564fed884887b481bf7abc28a
> ui: add color and progress extensions to progressive mode

NAK.

First, everyone seems to forget that progress has been green-lighted to
be included in core and on by default for years now. The only thing
holding it back is a handful of bugs like not working well with hgweb.
So it definitely doesn't belong connected to this feature.

Second, two changes but one patch.

Patch

diff --git a/mercurial/ui.py b/mercurial/ui.py
--- a/mercurial/ui.py
+++ b/mercurial/ui.py
@@ -484,6 +484,10 @@ 
             self.setconfig('diff', 'git', 'True')
         if not self.hasconfig('ui', 'statuscopies'):
             self.setconfig('ui', 'statuscopies', 'True')
+        if not self.hasconfig('extensions', 'color'):
+            self.setconfig('extensions', 'color', '')
+        if not self.hasconfig('extensions', 'progress'):
+            self.setconfig('extensions', 'progress', '')
 
     def plain(self, feature=None):
         '''is plain mode active?