Patchwork [1,of,2,V3] record_curses: add test for newly added files

login
register
mail settings
Submitter Laurent Charignon
Date March 26, 2015, 8:30 p.m.
Message ID <d2276d7c1db113d743e1.1427401853@dev919.prn2.facebook.com>
Download mbox | patch
Permalink /patch/8304/
State Accepted
Headers show

Comments

Laurent Charignon - March 26, 2015, 8:30 p.m.
# HG changeset patch
# User Laurent Charignon <lcharignon@fb.com>
# Date 1427326837 25200
#      Wed Mar 25 16:40:37 2015 -0700
# Node ID d2276d7c1db113d743e15929106bfe65edb2e804
# Parent  5b85a5bc5bbb9d8365953609d98e4dce7110e9b0
record_curses: add test for newly added files

We have a UI bug where toggling twice a newly added file in the curses
interface didn't mark it as selected. This test checks that the underlying
logic is working as expected, the next patch of the serie fixes the UI bug.

Patch

diff --git a/tests/test-commit-interactive-curses.t b/tests/test-commit-interactive-curses.t
--- a/tests/test-commit-interactive-curses.t
+++ b/tests/test-commit-interactive-curses.t
@@ -181,4 +181,23 @@ 
   This is the second line
   This is the third line
 
+Newly added files can be selected with the curses interface
 
+  $ hg update -C .
+  1 files updated, 0 files merged, 0 files removed, 0 files unresolved
+  $ echo "hello" > x
+  $ hg add x
+  $ cat <<EOF >testModeCommands
+  > TOGGLE
+  > TOGGLE
+  > X
+  > EOF
+  $ hg st
+  A x
+  ? editor.sh
+  ? testModeCommands
+  $ hg commit -i  -m "newly added file" -d "0 0"
+  $ hg st
+  ? editor.sh
+  ? testModeCommands
+