Patchwork test-tools: replace seq with seq.py for OS X support

login
register
mail settings
Submitter Matt Harbison
Date March 17, 2015, 6:39 p.m.
Message ID <0f37c06f44f4fa7c17f8.1426617590@waste.org>
Download mbox | patch
Permalink /patch/8124/
State Superseded
Headers show

Comments

Matt Harbison - March 17, 2015, 6:39 p.m.
# HG changeset patch
# User Matt Harbison <mharbison@attotech.com>
# Date 1426616484 14400
#      Tue Mar 17 14:21:24 2015 -0400
# Node ID 0f37c06f44f4fa7c17f85c84358f488f6a1c372b
# Parent  b7f936f47f2b104a60840bae571e009742126afc
test-tools: replace seq with seq.py for OS X support

10.6.8 doesn't have it, while 10.10 does.  I'm not sure when it was added.

There's a difference in this seq.py and the one proposed by foozy[1], in that
this starts at 1.  Otherwise, other test diffs occurred.

[1] http://www.selenic.com/pipermail/mercurial-devel/2015-March/067356.html
Augie Fackler - April 3, 2015, 2:48 p.m.
On Tue, Mar 17, 2015 at 01:39:50PM -0500, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <mharbison@attotech.com>
> # Date 1426616484 14400
> #      Tue Mar 17 14:21:24 2015 -0400
> # Node ID 0f37c06f44f4fa7c17f85c84358f488f6a1c372b
> # Parent  b7f936f47f2b104a60840bae571e009742126afc
> test-tools: replace seq with seq.py for OS X support

This got superseded and patchbot didn't notice. (I'm trying to clean
up the patchbot, not sure how to handle this case.)

>
> 10.6.8 doesn't have it, while 10.10 does.  I'm not sure when it was added.
>
> There's a difference in this seq.py and the one proposed by foozy[1], in that
> this starts at 1.  Otherwise, other test diffs occurred.
>
> [1] http://www.selenic.com/pipermail/mercurial-devel/2015-March/067356.html
>
> diff --git a/tests/test-tools.t b/tests/test-tools.t
> --- a/tests/test-tools.t
> +++ b/tests/test-tools.t
> @@ -1,4 +1,9 @@
>  Tests of the file helper tool
> +  $ cat > $TESTTMP/seq.py <<EOF
> +  > import sys
> +  > for i in xrange(*[int(a) for a in sys.argv[1:]]):
> +  >     print i+1
> +  > EOF
>
>    $ f -h
>    ?sage: f [options] [filenames] (glob)
> @@ -43,7 +48,7 @@
>    foo: mode=644
>  #endif
>
> -  $ seq 10 > bar
> +  $ python $TESTTMP/seq.py 10 > bar
>  #if unix-permissions symlink
>    $ chmod +x bar
>    $ f bar --newer foo --mode --type --size --dump --links --bytes 7
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel

Patch

diff --git a/tests/test-tools.t b/tests/test-tools.t
--- a/tests/test-tools.t
+++ b/tests/test-tools.t
@@ -1,4 +1,9 @@ 
 Tests of the file helper tool
+  $ cat > $TESTTMP/seq.py <<EOF
+  > import sys
+  > for i in xrange(*[int(a) for a in sys.argv[1:]]):
+  >     print i+1
+  > EOF
 
   $ f -h
   ?sage: f [options] [filenames] (glob)
@@ -43,7 +48,7 @@ 
   foo: mode=644
 #endif
 
-  $ seq 10 > bar
+  $ python $TESTTMP/seq.py 10 > bar
 #if unix-permissions symlink
   $ chmod +x bar
   $ f bar --newer foo --mode --type --size --dump --links --bytes 7