Patchwork incoming: hide help about use of --bundle option by default

login
register
mail settings
Submitter Yuya Nishihara
Date March 8, 2015, 11:57 a.m.
Message ID <62c4a963489d0ff8887b.1425815841@mimosa>
Download mbox | patch
Permalink /patch/7938/
State Accepted
Headers show

Comments

Yuya Nishihara - March 8, 2015, 11:57 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1424951645 -32400
#      Thu Feb 26 20:54:05 2015 +0900
# Node ID 62c4a963489d0ff8887b1e5d2c9458d1e3384536
# Parent  02d7b5cd373bbb4e8263dad9bfbf9c4c3b0e4e3a
incoming: hide help about use of --bundle option by default

Pulling from incoming bundle can cause trouble such as missing phase movement,
bookmarks and largefiles transfer. Average user won't need this option.
Pierre-Yves David - March 10, 2015, 12:43 a.m.
On 03/08/2015 04:57 AM, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1424951645 -32400
> #      Thu Feb 26 20:54:05 2015 +0900
> # Node ID 62c4a963489d0ff8887b1e5d2c9458d1e3384536
> # Parent  02d7b5cd373bbb4e8263dad9bfbf9c4c3b0e4e3a
> incoming: hide help about use of --bundle option by default

Sound a fair idea to me. Will lets someone else agree and actually push it

>
> Pulling from incoming bundle can cause trouble such as missing phase movement,
> bookmarks and largefiles transfer. Average user won't need this option.
>
> diff --git a/mercurial/commands.py b/mercurial/commands.py
> --- a/mercurial/commands.py
> +++ b/mercurial/commands.py
> @@ -4244,13 +4244,13 @@ def incoming(ui, repo, source="default",
>       pull location. These are the changesets that would have been pulled
>       if a pull at the time you issued this command.
>
> -    For remote repository, using --bundle avoids downloading the
> -    changesets twice if the incoming is followed by a pull.
> -
>       See pull for valid source format details.
>
>       .. container:: verbose
>
> +      For remote repository, using --bundle avoids downloading the
> +      changesets twice if the incoming is followed by a pull.
> +
>         Examples:
>
>         - show incoming changes with patches and full description::
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>
Augie Fackler - March 10, 2015, 1:39 p.m.
On Sun, Mar 08, 2015 at 08:57:21PM +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1424951645 -32400
> #      Thu Feb 26 20:54:05 2015 +0900
> # Node ID 62c4a963489d0ff8887b1e5d2c9458d1e3384536
> # Parent  02d7b5cd373bbb4e8263dad9bfbf9c4c3b0e4e3a
> incoming: hide help about use of --bundle option by default
>

I agree with marmoute, this is a good plan. Queued.

>
> Pulling from incoming bundle can cause trouble such as missing phase movement,
> bookmarks and largefiles transfer. Average user won't need this option.
>
> diff --git a/mercurial/commands.py b/mercurial/commands.py
> --- a/mercurial/commands.py
> +++ b/mercurial/commands.py
> @@ -4244,13 +4244,13 @@ def incoming(ui, repo, source="default",
>      pull location. These are the changesets that would have been pulled
>      if a pull at the time you issued this command.
>
> -    For remote repository, using --bundle avoids downloading the
> -    changesets twice if the incoming is followed by a pull.
> -
>      See pull for valid source format details.
>
>      .. container:: verbose
>
> +      For remote repository, using --bundle avoids downloading the
> +      changesets twice if the incoming is followed by a pull.
> +
>        Examples:
>
>        - show incoming changes with patches and full description::
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel

Patch

diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -4244,13 +4244,13 @@  def incoming(ui, repo, source="default",
     pull location. These are the changesets that would have been pulled
     if a pull at the time you issued this command.
 
-    For remote repository, using --bundle avoids downloading the
-    changesets twice if the incoming is followed by a pull.
-
     See pull for valid source format details.
 
     .. container:: verbose
 
+      For remote repository, using --bundle avoids downloading the
+      changesets twice if the incoming is followed by a pull.
+
       Examples:
 
       - show incoming changes with patches and full description::