| Submitter | Anton Shestakov |
|---|---|
| Date | Feb. 11, 2015, 6:21 p.m. |
| Message ID | <e0abaa13c5f9a1bbd66a.1423678863@neuro> |
| Download | mbox | patch |
| Permalink | /patch/7791/ |
| State | Accepted |
| Headers | show |
Comments
Anton Shestakov writes: > # HG changeset patch > # User Anton Shestakov <engored@ya.ru> > # Date 1420897062 -28800 > # Sat Jan 10 21:37:42 2015 +0800 > # Node ID e0abaa13c5f9a1bbd66ab0bab512cc1d7f67b924 > # Parent 30f75cfb42034da322cda471eee15814b28841d9 > hgweb: clearly outline <tr> block in paper/changeset.tmpl > > This particular <tr> block should use the style of its neighboring blocks, > otherwise it's easy to think that the closing '</tr>' is missing. These three patches look great.
On Wed, Feb 11, 2015 at 10:31:45AM -0800, Sean Farley wrote: > > Anton Shestakov writes: > > > # HG changeset patch > > # User Anton Shestakov <engored@ya.ru> > > # Date 1420897062 -28800 > > # Sat Jan 10 21:37:42 2015 +0800 > > # Node ID e0abaa13c5f9a1bbd66ab0bab512cc1d7f67b924 > > # Parent 30f75cfb42034da322cda471eee15814b28841d9 > > hgweb: clearly outline <tr> block in paper/changeset.tmpl > > > > This particular <tr> block should use the style of its neighboring blocks, > > otherwise it's easy to think that the closing '</tr>' is missing. > > These three patches look great. Agreed, queued for default. > _______________________________________________ > Mercurial-devel mailing list > Mercurial-devel@selenic.com > http://selenic.com/mailman/listinfo/mercurial-devel
Patch
diff --git a/mercurial/templates/paper/changeset.tmpl b/mercurial/templates/paper/changeset.tmpl --- a/mercurial/templates/paper/changeset.tmpl +++ b/mercurial/templates/paper/changeset.tmpl @@ -48,7 +48,8 @@ </tr> <tr> <th class="date">date</th> - <td class="date age">{date|rfc822date}</td></tr> + <td class="date age">{date|rfc822date}</td> +</tr> <tr> <th class="author">parents</th> <td class="author">{ifeq(count(parent), '2', parent%changesetparentdiff, parent%changesetparent)}</td> diff --git a/tests/test-hgweb-commands.t b/tests/test-hgweb-commands.t --- a/tests/test-hgweb-commands.t +++ b/tests/test-hgweb-commands.t @@ -874,7 +874,8 @@ Logs and changes </tr> <tr> <th class="date">date</th> - <td class="date age">Thu, 01 Jan 1970 00:00:00 +0000</td></tr> + <td class="date age">Thu, 01 Jan 1970 00:00:00 +0000</td> + </tr> <tr> <th class="author">parents</th> <td class="author"></td> diff --git a/tests/test-hgweb-diffs.t b/tests/test-hgweb-diffs.t --- a/tests/test-hgweb-diffs.t +++ b/tests/test-hgweb-diffs.t @@ -97,7 +97,8 @@ revision </tr> <tr> <th class="date">date</th> - <td class="date age">Thu, 01 Jan 1970 00:00:00 +0000</td></tr> + <td class="date age">Thu, 01 Jan 1970 00:00:00 +0000</td> + </tr> <tr> <th class="author">parents</th> <td class="author"></td> @@ -368,7 +369,8 @@ revision </tr> <tr> <th class="date">date</th> - <td class="date age">Thu, 01 Jan 1970 00:00:00 +0000</td></tr> + <td class="date age">Thu, 01 Jan 1970 00:00:00 +0000</td> + </tr> <tr> <th class="author">parents</th> <td class="author"></td> diff --git a/tests/test-hgweb-removed.t b/tests/test-hgweb-removed.t --- a/tests/test-hgweb-removed.t +++ b/tests/test-hgweb-removed.t @@ -78,7 +78,8 @@ revision </tr> <tr> <th class="date">date</th> - <td class="date age">Thu, 01 Jan 1970 00:00:00 +0000</td></tr> + <td class="date age">Thu, 01 Jan 1970 00:00:00 +0000</td> + </tr> <tr> <th class="author">parents</th> <td class="author"><a href="/rev/cb9a9f314b8b">cb9a9f314b8b</a> </td>