Patchwork hgweb: don't attempt to show hidden bookmarks (issue3774)

login
register
mail settings
Submitter Kevin Bullock
Date Jan. 25, 2013, 6:05 p.m.
Message ID <b79595153b6546c8962e.1359137122@vpn0-77.vpn.umn.edu>
Download mbox | patch
Permalink /patch/737/
State Superseded
Headers show

Comments

Kevin Bullock - Jan. 25, 2013, 6:05 p.m.
# HG changeset patch
# User Kevin Bullock <kbullock@ringworld.org>
# Date 1359135834 21600
# Branch stable
# Node ID b79595153b6546c8962ef60a402dc21c613849c7
# Parent  075143f60807c96fd051fd1dde5830852e4e6099
hgweb: don't attempt to show hidden bookmarks (issue3774)
Pierre-Yves David - Jan. 25, 2013, 6:28 p.m.
On Fri, Jan 25, 2013 at 12:05:22PM -0600, Kevin Bullock wrote:
> # HG changeset patch
> # User Kevin Bullock <kbullock@ringworld.org>
> # Date 1359135834 21600
> # Branch stable
> # Node ID b79595153b6546c8962ef60a402dc21c613849c7
> # Parent  075143f60807c96fd051fd1dde5830852e4e6099
> hgweb: don't attempt to show hidden bookmarks (issue3774)


We probably wants a new test that check it's not broken anymore too.

Patch

diff --git a/mercurial/hgweb/webcommands.py b/mercurial/hgweb/webcommands.py
--- a/mercurial/hgweb/webcommands.py
+++ b/mercurial/hgweb/webcommands.py
@@ -424,7 +424,7 @@  def tags(web, req, tmpl):
                 latestentry=lambda **x: entries(True, True, **x))
 
 def bookmarks(web, req, tmpl):
-    i = web.repo._bookmarks.items()
+    i = [b for b in web.repo._bookmarks.items() if b[1] in web.repo]
     parity = paritygen(web.stripecount)
 
     def entries(latestonly, **map):