Patchwork [1,of,2] templates: remove unnecessary <span>

login
register
mail settings
Submitter Gregory Szorc
Date Jan. 6, 2015, 11:29 p.m.
Message ID <abf6600f3abb79713005.1420586980@3.1.168.192.in-addr.arpa>
Download mbox | patch
Permalink /patch/7341/
State Accepted
Commit 606a3bf82e3030d1e612be50b9943f4379675415
Headers show

Comments

Gregory Szorc - Jan. 6, 2015, 11:29 p.m.
# HG changeset patch
# User Gregory Szorc <gregory.szorc@gmail.com>
# Date 1420586508 28800
#      Tue Jan 06 15:21:48 2015 -0800
# Node ID abf6600f3abb79713005d0fd93016925effa4ebf
# Parent  d944492445fa0d0b9c164336afab68127080a1f3
templates: remove unnecessary <span>

The <span> on diffline was useless. It was only making browsers work
harder. Remove it.

Patch

diff --git a/mercurial/templates/gitweb/map b/mercurial/templates/gitweb/map
--- a/mercurial/templates/gitweb/map
+++ b/mercurial/templates/gitweb/map
@@ -107,9 +107,9 @@  annotateline = '
   </tr>'
 difflineplus = '<span style="color:#008800;"><a class="linenr" href="#{lineid}" id="{lineid}">{linenumber}</a> {line|escape}</span>'
 difflineminus = '<span style="color:#cc0000;"><a class="linenr" href="#{lineid}" id="{lineid}">{linenumber}</a> {line|escape}</span>'
 difflineat = '<span style="color:#990099;"><a class="linenr" href="#{lineid}" id="{lineid}">{linenumber}</a> {line|escape}</span>'
-diffline = '<span><a class="linenr" href="#{lineid}" id="{lineid}">{linenumber}</a> {line|escape}</span>'
+diffline = '<a class="linenr" href="#{lineid}" id="{lineid}">{linenumber}</a> {line|escape}'
 
 comparisonblock ='
   <tbody class="block">
   {lines}
diff --git a/mercurial/templates/monoblue/map b/mercurial/templates/monoblue/map
--- a/mercurial/templates/monoblue/map
+++ b/mercurial/templates/monoblue/map
@@ -102,9 +102,9 @@  annotateline = '
   </tr>'
 difflineplus = '<span style="color:#008800;"><a class="linenr" href="#{lineid}" id="{lineid}">{linenumber}</a> {line|escape}</span>'
 difflineminus = '<span style="color:#cc0000;"><a class="linenr" href="#{lineid}" id="{lineid}">{linenumber}</a> {line|escape}</span>'
 difflineat = '<span style="color:#990099;"><a class="linenr" href="#{lineid}" id="{lineid}">{linenumber}</a> {line|escape}</span>'
-diffline = '<span><a class="linenr" href="#{lineid}" id="{lineid}">{linenumber}</a> {line|escape}</span>'
+diffline = '<a class="linenr" href="#{lineid}" id="{lineid}">{linenumber}</a> {line|escape}'
 
 comparisonblock ='
   <tbody class="block">
   {lines}