Patchwork [2,of,2] largefiles: drop the unfiltered repo usage in overridepurge()

login
register
mail settings
Submitter Matt Harbison
Date Dec. 9, 2014, 2:31 a.m.
Message ID <c37bb6760397910e5a05.1418092292@Envy>
Download mbox | patch
Permalink /patch/7027/
State Accepted
Commit ca54fb3d71ce73d2e10cc2358a9165af216c781e
Headers show

Comments

Matt Harbison - Dec. 9, 2014, 2:31 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1417967669 18000
#      Sun Dec 07 10:54:29 2014 -0500
# Node ID c37bb6760397910e5a05026df1555507b20f7aea
# Parent  299fc395d9c4f633a07ef08187f46151ca0ab298
largefiles: drop the unfiltered repo usage in overridepurge()

Now that repoview supports replacing methods, we don't need this hack.
Matt Mackall - Dec. 9, 2014, 6:03 p.m.
On Mon, 2014-12-08 at 21:31 -0500, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <matt_harbison@yahoo.com>
> # Date 1417967669 18000
> #      Sun Dec 07 10:54:29 2014 -0500
> # Node ID c37bb6760397910e5a05026df1555507b20f7aea
> # Parent  299fc395d9c4f633a07ef08187f46151ca0ab298
> largefiles: drop the unfiltered repo usage in overridepurge()

Seems reasonable, queued for default, thanks.

Patch

diff --git a/hgext/largefiles/overrides.py b/hgext/largefiles/overrides.py
--- a/hgext/largefiles/overrides.py
+++ b/hgext/largefiles/overrides.py
@@ -1110,9 +1110,6 @@ 
 # Calling purge with --all will cause the largefiles to be deleted.
 # Override repo.status to prevent this from happening.
 def overridepurge(orig, ui, repo, *dirs, **opts):
-    # XXX large file status is buggy when used on repo proxy.
-    # XXX this needs to be investigate.
-    repo = repo.unfiltered()
     oldstatus = repo.status
     def overridestatus(node1='.', node2=None, match=None, ignored=False,
                         clean=False, unknown=False, listsubrepos=False):