Patchwork [1,of,3,hg-2.5] run-tests.py: backout "don't use console for stdin when running in debug mode"

login
register
mail settings
Submitter Mads Kiilerich
Date Jan. 19, 2013, 12:18 a.m.
Message ID <dfd172372e2a9b213f02.1358554711@mk-desktop>
Download mbox | patch
Permalink /patch/682/
State Accepted
Commit e760414be20164dd479a3d325214c709d76aee0d
Headers show

Comments

Mads Kiilerich - Jan. 19, 2013, 12:18 a.m.
# HG changeset patch
# User Mads Kiilerich <madski@unity3d.com>
# Date 1358468176 -3600
# Node ID dfd172372e2a9b213f02ea1184dfcb2d1ca35fb1
# Parent  1f794204abbd7dd4bc329ae0c7c4fd7ce56b33af
run-tests.py: backout "don't use console for stdin when running in debug mode"

f5842787a958 caused that some kind of interactive debugging no longer was
possible - such as running hg with --debugger in a test run with run-tests.py
--debug .

Patch

diff --git a/tests/run-tests.py b/tests/run-tests.py
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -751,8 +751,7 @@ 
     Return a tuple (exitcode, output).  output is None in debug mode."""
     # TODO: Use subprocess.Popen if we're running on Python 2.4
     if options.debug:
-        proc = subprocess.Popen(cmd, shell=True, cwd=wd, stdin=subprocess.PIPE)
-        proc.stdin.close()
+        proc = subprocess.Popen(cmd, shell=True, cwd=wd)
         ret = proc.wait()
         return (ret, None)