Patchwork revset.only: use cl.findmissingrevs

login
register
mail settings
Submitter Siddharth Agarwal
Date Nov. 15, 2014, 12:40 a.m.
Message ID <d733796b4362918f2eb1.1416012025@devbig136.prn2.facebook.com>
Download mbox | patch
Permalink /patch/6741/
State Accepted
Commit d716b1cec5cf08ad46d73130bcc170905d81c7e3
Headers show

Comments

Siddharth Agarwal - Nov. 15, 2014, 12:40 a.m.
# HG changeset patch
# User Siddharth Agarwal <sid0@fb.com>
# Date 1416011938 28800
#      Fri Nov 14 16:38:58 2014 -0800
# Node ID d733796b4362918f2eb10e5d6323becb02054bcc
# Parent  991098579940552536d0a99fa3602dd1661aa388
revset.only: use cl.findmissingrevs

ancestor.missingancestors is really an implementation detail.
Matt Mackall - Nov. 17, 2014, 10:35 p.m.
On Fri, 2014-11-14 at 16:40 -0800, Siddharth Agarwal wrote:
> # HG changeset patch
> # User Siddharth Agarwal <sid0@fb.com>
> # Date 1416011938 28800
> #      Fri Nov 14 16:38:58 2014 -0800
> # Node ID d733796b4362918f2eb10e5d6323becb02054bcc
> # Parent  991098579940552536d0a99fa3602dd1661aa388
> revset.only: use cl.findmissingrevs

Queued for default, thanks.

Patch

diff --git a/mercurial/revset.py b/mercurial/revset.py
--- a/mercurial/revset.py
+++ b/mercurial/revset.py
@@ -10,7 +10,6 @@ 
 import node
 import heapq
 import match as matchmod
-import ancestor as ancestormod
 from i18n import _
 import encoding
 import obsolete as obsmod
@@ -406,7 +405,7 @@ 
     else:
         exclude = getset(repo, spanset(repo), args[1])
 
-    results = set(ancestormod.missingancestors(include, exclude, cl.parentrevs))
+    results = set(cl.findmissingrevs(common=exclude, heads=include))
     return subset & results
 
 def bisect(repo, subset, x):