Patchwork hgignore: ignore the PyCharm workspace folder

login
register
mail settings
Submitter Angel Ezquerra
Date Oct. 13, 2014, 9:48 a.m.
Message ID <a175222b250090e80a60.1413193686@Angels-MacBook-Pro.local>
Download mbox | patch
Permalink /patch/6235/
State Accepted
Headers show

Comments

Angel Ezquerra - Oct. 13, 2014, 9:48 a.m.
# HG changeset patch
# User Angel Ezquerra <angel.ezquerra@gmail.com>
# Date 1413193564 -7200
#      Mon Oct 13 11:46:04 2014 +0200
# Node ID a175222b250090e80a6047979451bfdbaf04267c
# Parent  76a648d782cfadf1dac3dbc194a8ffc74c385cb5
hgignore: ignore the PyCharm workspace folder
Mads Kiilerich - Oct. 13, 2014, 12:14 p.m.
On 10/13/2014 11:48 AM, Angel Ezquerra wrote:
> # HG changeset patch
> # User Angel Ezquerra <angel.ezquerra@gmail.com>
> # Date 1413193564 -7200
> #      Mon Oct 13 11:46:04 2014 +0200
> # Node ID a175222b250090e80a6047979451bfdbaf04267c
> # Parent  76a648d782cfadf1dac3dbc194a8ffc74c385cb5
> hgignore: ignore the PyCharm workspace folder
>
> diff -r 76a648d782cf -r a175222b2500 .hgignore
> --- a/.hgignore	Tue Sep 02 09:01:47 2014 +0200
> +++ b/.hgignore	Mon Oct 13 11:46:04 2014 +0200
> @@ -42,6 +42,7 @@
>   .DS_Store
>   tags
>   cscope.*
> +.idea/*
>   i18n/hg.pot
>   locale/*/LC_MESSAGES/hg.mo
>   hgext/__index__.py

It doesn't work at scale to add ignore patterns for every single IDE out 
there. Especially not partly proprietary ones. Wouldn't it be better if 
pycharm users put this in their ui.ignore file?

/Mads
Angel Ezquerra - Oct. 13, 2014, 12:59 p.m.
El 13/10/2014 14:14, "Mads Kiilerich" <mads@kiilerich.com> escribió:
>
> On 10/13/2014 11:48 AM, Angel Ezquerra wrote:
>>
>> # HG changeset patch
>> # User Angel Ezquerra <angel.ezquerra@gmail.com>
>> # Date 1413193564 -7200
>> #      Mon Oct 13 11:46:04 2014 +0200
>> # Node ID a175222b250090e80a6047979451bfdbaf04267c
>> # Parent  76a648d782cfadf1dac3dbc194a8ffc74c385cb5
>> hgignore: ignore the PyCharm workspace folder
>>
>> diff -r 76a648d782cf -r a175222b2500 .hgignore
>> --- a/.hgignore Tue Sep 02 09:01:47 2014 +0200
>> +++ b/.hgignore Mon Oct 13 11:46:04 2014 +0200
>> @@ -42,6 +42,7 @@
>>   .DS_Store
>>   tags
>>   cscope.*
>> +.idea/*
>>   i18n/hg.pot
>>   locale/*/LC_MESSAGES/hg.mo
>>   hgext/__index__.py
>
>
> It doesn't work at scale to add ignore patterns for every single IDE out
there. Especially not partly proprietary ones. Wouldn't it be better if
pycharm users put this in their ui.ignore file?
>
> /Mads
>

I see your point but the reality is that there are not that many Python
IDEs with a large user base. I could name 4 or 5 IDEs that are really
popular. If we include some popular text editors the list could maybe be
extended to about a dozen. Would adding that many extra lines to
mercurial's hgignore file be a problem, considering that they would be
added on a case by case basis (i.e. when someone sent a patch such as this
one)?

Anyway, I can see your point. I'd prefer having this in, but if you guys
don't feel the same that would be ok too.

Cheers,

Angel
Pierre-Yves David - Oct. 13, 2014, 6:46 p.m.
On 10/13/2014 05:59 AM, Angel Ezquerra wrote:
>
> El 13/10/2014 14:14, "Mads Kiilerich" <mads@kiilerich.com
> <mailto:mads@kiilerich.com>> escribió:
>  >
>  > On 10/13/2014 11:48 AM, Angel Ezquerra wrote:
>  >>
>  >> # HG changeset patch
>  >> # User Angel Ezquerra <angel.ezquerra@gmail.com
> <mailto:angel.ezquerra@gmail.com>>
>  >> # Date 1413193564 -7200
>  >> #      Mon Oct 13 11:46:04 2014 +0200
>  >> # Node ID a175222b250090e80a6047979451bfdbaf04267c
>  >> # Parent  76a648d782cfadf1dac3dbc194a8ffc74c385cb5
>  >> hgignore: ignore the PyCharm workspace folder
>  >>
>  >> diff -r 76a648d782cf -r a175222b2500 .hgignore
>  >> --- a/.hgignore Tue Sep 02 09:01:47 2014 +0200
>  >> +++ b/.hgignore Mon Oct 13 11:46:04 2014 +0200
>  >> @@ -42,6 +42,7 @@
>  >>   .DS_Store
>  >>   tags
>  >>   cscope.*
>  >> +.idea/*
>  >>   i18n/hg.pot
>  >>   locale/*/LC_MESSAGES/hg.mo
>  >>   hgext/__index__.py
>  >
>  >
>  > It doesn't work at scale to add ignore patterns for every single IDE
> out there. Especially not partly proprietary ones. Wouldn't it be better
> if pycharm users put this in their ui.ignore file?
>  >
>  > /Mads
>  >
>
> I see your point but the reality is that there are not that many Python
> IDEs with a large user base. I could name 4 or 5 IDEs that are really
> popular. If we include some popular text editors the list could maybe be
> extended to about a dozen. Would adding that many extra lines to
> mercurial's hgignore file be a problem, considering that they would be
> added on a case by case basis (i.e. when someone sent a patch such as
> this one)?
>
> Anyway, I can see your point. I'd prefer having this in, but if you guys
> don't feel the same that would be ok too.

Not fan of adding all possibles IDE there. But we already have ignores 
for emacs and vim file. I can see Angel point about popular IDE. +0 on this.
Brendan Cully - Oct. 13, 2014, 11:05 p.m.
On Monday, 13 October 2014 at 14:59, Angel Ezquerra wrote:
> El 13/10/2014 14:14, "Mads Kiilerich" <mads@kiilerich.com> escribió:
> >
> > On 10/13/2014 11:48 AM, Angel Ezquerra wrote:
> >>
> >> # HG changeset patch
> >> # User Angel Ezquerra <angel.ezquerra@gmail.com>
> >> # Date 1413193564 -7200
> >> #      Mon Oct 13 11:46:04 2014 +0200
> >> # Node ID a175222b250090e80a6047979451bfdbaf04267c
> >> # Parent  76a648d782cfadf1dac3dbc194a8ffc74c385cb5
> >> hgignore: ignore the PyCharm workspace folder
> >>
> >> diff -r 76a648d782cf -r a175222b2500 .hgignore
> >> --- a/.hgignore Tue Sep 02 09:01:47 2014 +0200
> >> +++ b/.hgignore Mon Oct 13 11:46:04 2014 +0200
> >> @@ -42,6 +42,7 @@
> >>   .DS_Store
> >>   tags
> >>   cscope.*
> >> +.idea/*
> >>   i18n/hg.pot
> >>   locale/*/LC_MESSAGES/hg.mo
> >>   hgext/__index__.py
> >
> >
> > It doesn't work at scale to add ignore patterns for every single IDE out
> there. Especially not partly proprietary ones. Wouldn't it be better if
> pycharm users put this in their ui.ignore file?
> >
> > /Mads
> >
> 
> I see your point but the reality is that there are not that many Python
> IDEs with a large user base. I could name 4 or 5 IDEs that are really
> popular. If we include some popular text editors the list could maybe be
> extended to about a dozen. Would adding that many extra lines to
> mercurial's hgignore file be a problem, considering that they would be
> added on a case by case basis (i.e. when someone sent a patch such as this
> one)?

This sounds right to me. I'm +1 on ignoring ^\.idea/
Martin Geisler - Oct. 14, 2014, 8:01 a.m.
Pierre-Yves David <pierre-yves.david@ens-lyon.org> writes:

> On 10/13/2014 05:59 AM, Angel Ezquerra wrote:
>>
>> El 13/10/2014 14:14, "Mads Kiilerich" <mads@kiilerich.com
>> <mailto:mads@kiilerich.com>> escribió:
>>  >
>>  > On 10/13/2014 11:48 AM, Angel Ezquerra wrote:
>>  >>
>>  >> # HG changeset patch
>>  >> # User Angel Ezquerra <angel.ezquerra@gmail.com
>> <mailto:angel.ezquerra@gmail.com>>
>>  >> # Date 1413193564 -7200
>>  >> #      Mon Oct 13 11:46:04 2014 +0200
>>  >> # Node ID a175222b250090e80a6047979451bfdbaf04267c
>>  >> # Parent  76a648d782cfadf1dac3dbc194a8ffc74c385cb5
>>  >> hgignore: ignore the PyCharm workspace folder
>>  >>
>>  >> diff -r 76a648d782cf -r a175222b2500 .hgignore
>>  >> --- a/.hgignore Tue Sep 02 09:01:47 2014 +0200
>>  >> +++ b/.hgignore Mon Oct 13 11:46:04 2014 +0200
>>  >> @@ -42,6 +42,7 @@
>>  >>   .DS_Store
>>  >>   tags
>>  >>   cscope.*
>>  >> +.idea/*
>>  >>   i18n/hg.pot
>>  >>   locale/*/LC_MESSAGES/hg.mo
>>  >>   hgext/__index__.py
>>  >
>>  >
>>  > It doesn't work at scale to add ignore patterns for every single IDE
>> out there. Especially not partly proprietary ones. Wouldn't it be better
>> if pycharm users put this in their ui.ignore file?
>>  >
>>  > /Mads
>>  >
>>
>> I see your point but the reality is that there are not that many Python
>> IDEs with a large user base. I could name 4 or 5 IDEs that are really
>> popular. If we include some popular text editors the list could maybe be
>> extended to about a dozen. Would adding that many extra lines to
>> mercurial's hgignore file be a problem, considering that they would be
>> added on a case by case basis (i.e. when someone sent a patch such as
>> this one)?
>>
>> Anyway, I can see your point. I'd prefer having this in, but if you guys
>> don't feel the same that would be ok too.
>
> Not fan of adding all possibles IDE there. But we already have ignores
> for emacs and vim file. I can see Angel point about popular IDE. +0 on
> this.

I think adding patterns for popular IDEs makes a lot of sense. It will
make things nicer out of the box for these developers. Here I would
simply define "popular" as being used enough that someone cares to
submit such a patch :)
Pierre-Yves David - Oct. 15, 2014, 10:36 a.m.
On 10/13/2014 02:48 AM, Angel Ezquerra wrote:
> # HG changeset patch
> # User Angel Ezquerra <angel.ezquerra@gmail.com>
> # Date 1413193564 -7200
> #      Mon Oct 13 11:46:04 2014 +0200
> # Node ID a175222b250090e80a6047979451bfdbaf04267c
> # Parent  76a648d782cfadf1dac3dbc194a8ffc74c385cb5
> hgignore: ignore the PyCharm workspace folder

I've move forward and pushed this patch to the clowncopter.

Patch

diff -r 76a648d782cf -r a175222b2500 .hgignore
--- a/.hgignore	Tue Sep 02 09:01:47 2014 +0200
+++ b/.hgignore	Mon Oct 13 11:46:04 2014 +0200
@@ -42,6 +42,7 @@ 
 .DS_Store
 tags
 cscope.*
+.idea/*
 i18n/hg.pot
 locale/*/LC_MESSAGES/hg.mo
 hgext/__index__.py