Patchwork [5,of,5,V2] test-commandserver: make sure prompt does not echo input by default

login
register
mail settings
Submitter Yuya Nishihara
Date Oct. 10, 2014, 3:09 p.m.
Message ID <9be8527abfb2025df426.1412953761@mimosa>
Download mbox | patch
Permalink /patch/6178/
State Deferred
Headers show

Comments

Yuya Nishihara - Oct. 10, 2014, 3:09 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1412769061 -32400
#      Wed Oct 08 20:51:01 2014 +0900
# Node ID 9be8527abfb2025df426db3c362846d21493e538
# Parent  6dcb36c1781c7afbdcee20c793be20e90854e391
test-commandserver: make sure prompt does not echo input by default
Pierre-Yves David - Oct. 18, 2014, 10 p.m.
On 10/10/2014 08:09 AM, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1412769061 -32400
> #      Wed Oct 08 20:51:01 2014 +0900
> # Node ID 9be8527abfb2025df426db3c362846d21493e538
> # Parent  6dcb36c1781c7afbdcee20c793be20e90854e391
> test-commandserver: make sure prompt does not echo input by default

What is the status of this? Is the command server broken with current tip?
Yuya Nishihara - Oct. 19, 2014, 3:24 a.m.
On Sat, 18 Oct 2014 15:00:12 -0700, Pierre-Yves David wrote:
> On 10/10/2014 08:09 AM, Yuya Nishihara wrote:
> > # HG changeset patch
> > # User Yuya Nishihara <yuya@tcha.org>
> > # Date 1412769061 -32400
> > #      Wed Oct 08 20:51:01 2014 +0900
> > # Node ID 9be8527abfb2025df426db3c362846d21493e538
> > # Parent  6dcb36c1781c7afbdcee20c793be20e90854e391
> > test-commandserver: make sure prompt does not echo input by default
> 
> What is the status of this? Is the command server broken with current tip?

No, it was addressed by less readable version:
http://selenic.com/repo/hg/rev/524b786bd54f

Regards,

Patch

diff --git a/tests/test-commandserver.t b/tests/test-commandserver.t
--- a/tests/test-commandserver.t
+++ b/tests/test-commandserver.t
@@ -497,6 +497,9 @@  check that local configs for the cached 
   > @command("debuggetpass", norepo=True)
   > def debuggetpass(ui):
   >     ui.write("%s\\n" % ui.getpass())
+  > @command("debugprompt", norepo=True)
+  > def debugprompt(ui):
+  >     ui.write("%s\\n" % ui.prompt("prompt:"))
   > EOF
   $ cat <<EOF >> .hg/hgrc
   > [extensions]
@@ -511,8 +514,13 @@  check that local configs for the cached 
   ...     runcommand(server, ['debuggetpass', '--config',
   ...                         'ui.interactive=True'],
   ...                input=cStringIO.StringIO('1234\n'))
+  ...     runcommand(server, ['debugprompt', '--config',
+  ...                         'ui.interactive=True'],
+  ...                input=cStringIO.StringIO('5678\n'))
   *** runcommand debuggetpass --config ui.interactive=True
   password: 1234
+  *** runcommand debugprompt --config ui.interactive=True
+  prompt: 5678
 
 
 start without repository: