Patchwork [v2] repoview: remove hiddencache verification

login
register
mail settings
Submitter David Soria Parra
Date Oct. 6, 2014, 3:24 p.m.
Message ID <3a7a2a231b0482e9cece.1412609054@davidsp-mbp.local>
Download mbox | patch
Permalink /patch/6147/
State Accepted
Headers show

Comments

David Soria Parra - Oct. 6, 2014, 3:24 p.m.
# HG changeset patch
# User David Soria Parra <davidsp@fb.com>
# Date 1412605780 25200
#      Mon Oct 06 07:29:40 2014 -0700
# Node ID 3a7a2a231b0482e9cece8e51890690eaa87a8f37
# Parent  44dce874de97a2b3d47cc8be97432cbfcffddbe1
repoview: remove hiddencache verification

We have been running hiddencache verification since 3.1.1 and so
far not received a bug report concerning it. Therefore we remove
the verification code and make the hiddencache authoritive. That
way we get the intended speedup.
Matt Mackall - Oct. 6, 2014, 7:14 p.m.
On Mon, 2014-10-06 at 08:24 -0700, David Soria Parra wrote:
> # HG changeset patch
> # User David Soria Parra <davidsp@fb.com>
> # Date 1412605780 25200
> #      Mon Oct 06 07:29:40 2014 -0700
> # Node ID 3a7a2a231b0482e9cece8e51890690eaa87a8f37
> # Parent  44dce874de97a2b3d47cc8be97432cbfcffddbe1
> repoview: remove hiddencache verification

Queued for default, thanks.

Patch

diff --git a/mercurial/repoview.py b/mercurial/repoview.py
--- a/mercurial/repoview.py
+++ b/mercurial/repoview.py
@@ -138,14 +138,6 @@ 
             blocked = cl.ancestors(_getstaticblockers(repo), inclusive=True)
             hidden = frozenset(r for r in hideable if r not in blocked)
             trywritehiddencache(repo, hideable, hidden)
-        elif repo.ui.configbool('experimental', 'verifyhiddencache', True):
-            blocked = cl.ancestors(_getstaticblockers(repo), inclusive=True)
-            computed = frozenset(r for r in hideable if r not in blocked)
-            if computed != hidden:
-                trywritehiddencache(repo, hideable, computed)
-                repo.ui.warn(_('Cache inconsistency detected. Please ' +
-                    'open an issue on http://bz.selenic.com.\n'))
-                hidden = computed
 
         # check if we have wd parents, bookmarks or tags pointing to hidden
         # changesets and remove those.