Patchwork [evolve-ext] evolve: fix the 'grab' alias to work on Windows

login
register
mail settings
Submitter Matt Harbison
Date Sept. 4, 2014, 2:30 a.m.
Message ID <5407CEC1.9080902@yahoo.com>
Download mbox | patch
Permalink /patch/5694/
State Accepted
Headers show

Comments

Matt Harbison - Sept. 4, 2014, 2:30 a.m.
Pierre-Yves David wrote:
>
>
> On 08/13/2014 02:24 AM, Matt Harbison wrote:
>> On Tue, 12 Aug 2014 19:56:26 -0400, Matt Harbison wrote:
>>
>>> # HG changeset patch
>>> # User Matt Harbison <matt_harbison@yahoo.com>
>>> # Date 1407884993 14400
>>> # Tue Aug 12 19:09:53 2014 -0400
>>> # Node ID 51cda4d2bb2cd52f4e90bf35c4243e33c8ec71bb
>>> # Parent 66f4c5c52d970f145cd218ceed065c3fe096631d
>>> evolve: fix the 'grab' alias to work on Windows
>>>
>>> $ ../../hg/tests/run-tests.py --with-hg=../../hg/hg --blacklist windows
>>> Skipped test-simple4server.t: blacklisted
>>> Warned test-obsolete.t: no result code from test
>>> Warned test-tutorial.t: no result code from test
>>> Warned test-evolve.t: no result code from test
>>> Warned test-userguide.t: no result code from test
>>> Warned test-sharing.t: no result code from test
>>> Warned test-drop.t: no result code from test
>
> Not sure what this Warnings mean. Greg do you have and idea ?
>
>>> Failed test-prune.t: output changed
>>> # Ran 41 tests, 1 skipped, 6 warned, 1 failed.
>>
>> The prune failure seems like a real bug in evolve d2fe19c818ea /
>> hg fff8e1cec90f:
>
> A clowny bug was recently detected by windows. Can you try again with
> public stable heads of Mercurial ?

I ran it with the default heads, since the tests run much cleaner there 
with the change in how the date is printed with debugobsolete.  I merged 
hg 5c153c69fdb2 (default) and 71227dc24311 (stable), and ran with evolve 
1c227ecb744d + the real grab fix series I just posted, and got the same 
test difference:



--Matt
Pierre-Yves David - Sept. 11, 2014, 2:55 p.m.
On 09/04/2014 04:30 AM, Matt Harbison wrote:
> Pierre-Yves David wrote:
>>
>>
>> On 08/13/2014 02:24 AM, Matt Harbison wrote:
>>> On Tue, 12 Aug 2014 19:56:26 -0400, Matt Harbison wrote:
>>>
>>>> # HG changeset patch
>>>> # User Matt Harbison <matt_harbison@yahoo.com>
>>>> # Date 1407884993 14400
>>>> # Tue Aug 12 19:09:53 2014 -0400
>>>> # Node ID 51cda4d2bb2cd52f4e90bf35c4243e33c8ec71bb
>>>> # Parent 66f4c5c52d970f145cd218ceed065c3fe096631d
>>>> evolve: fix the 'grab' alias to work on Windows
>>>>
>>>> $ ../../hg/tests/run-tests.py --with-hg=../../hg/hg --blacklist windows
>>>> Skipped test-simple4server.t: blacklisted
>>>> Warned test-obsolete.t: no result code from test
>>>> Warned test-tutorial.t: no result code from test
>>>> Warned test-evolve.t: no result code from test
>>>> Warned test-userguide.t: no result code from test
>>>> Warned test-sharing.t: no result code from test
>>>> Warned test-drop.t: no result code from test
>>
>> Not sure what this Warnings mean. Greg do you have and idea ?
>>
>>>> Failed test-prune.t: output changed
>>>> # Ran 41 tests, 1 skipped, 6 warned, 1 failed.
>>>
>>> The prune failure seems like a real bug in evolve d2fe19c818ea /
>>> hg fff8e1cec90f:
>>
>> A clowny bug was recently detected by windows. Can you try again with
>> public stable heads of Mercurial ?
>
> I ran it with the default heads, since the tests run much cleaner there
> with the change in how the date is printed with debugobsolete.  I merged
> hg 5c153c69fdb2 (default) and 71227dc24311 (stable), and ran with evolve
> 1c227ecb744d + the real grab fix series I just posted, and got the same
> test difference:

Ok there is probably something stupid going with bookmark. Will probably 
be fixed when me moves bookmark into the transaction (soon™)

Patch

diff --git a/tests/test-prune.t b/tests/test-prune.t
--- a/tests/test-prune.t
+++ b/tests/test-prune.t
@@ -257,6 +261,7 @@ 
    $ hg bookmarks
       B                         10:ff43616e5d0f
       delete                    6:2702dd0c91e7
+     todelete                  8:d62d843c9a01
    $ hg prune -B delete
    3 changesets pruned
    bookmark 'delete' deleted