Patchwork revsetbenchmark: add revset with lazyset subtraction

login
register
mail settings
Submitter Gregory Szorc
Date Aug. 30, 2014, 1:17 p.m.
Message ID <d7145115338e8b7fc90a.1409404669@gps-mbp.local>
Download mbox | patch
Permalink /patch/5637/
State Accepted
Headers show

Comments

Gregory Szorc - Aug. 30, 2014, 1:17 p.m.
# HG changeset patch
# User Gregory Szorc <gregory.szorc@gmail.com>
# Date 1409404657 -7200
#      Sat Aug 30 15:17:37 2014 +0200
# Node ID d7145115338e8b7fc90aeba50b78f289e7ae682e
# Parent  bdc0e04df243d3995c7266bf7d138fddd0449ba6
revsetbenchmark: add revset with lazyset subtraction

The added revset is used by obsolescence and currently results in
recursion in __contains__ between 2 lazysets. We should have
coverage of this revset.
Matt Mackall - Aug. 30, 2014, 1:36 p.m.
On Sat, 2014-08-30 at 15:17 +0200, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc <gregory.szorc@gmail.com>
> # Date 1409404657 -7200
> #      Sat Aug 30 15:17:37 2014 +0200
> # Node ID d7145115338e8b7fc90aeba50b78f289e7ae682e
> # Parent  bdc0e04df243d3995c7266bf7d138fddd0449ba6
> revsetbenchmark: add revset with lazyset subtraction

Queued for default, thanks.
Pierre-Yves David - Sept. 2, 2014, 7:12 p.m.
On 08/30/2014 03:17 PM, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc <gregory.szorc@gmail.com>
> # Date 1409404657 -7200
> #      Sat Aug 30 15:17:37 2014 +0200
> # Node ID d7145115338e8b7fc90aeba50b78f289e7ae682e
> # Parent  bdc0e04df243d3995c7266bf7d138fddd0449ba6
> revsetbenchmark: add revset with lazyset subtraction
>
> The added revset is used by obsolescence and currently results in
> recursion in __contains__ between 2 lazysets. We should have
> coverage of this revset.

It is usually useful to include timing for @ and 2.9 to get people 
shocked about the slowdown.

Patch

diff --git a/contrib/revsetbenchmarks.txt b/contrib/revsetbenchmarks.txt
--- a/contrib/revsetbenchmarks.txt
+++ b/contrib/revsetbenchmarks.txt
@@ -21,4 +21,5 @@  public()
 draft()
 :10000 and draft()
 max(::(tip~20) - obsolete())
 roots((0:tip)::)
+(not public() - obsolete())