Patchwork [3,of,8] obsstore: add a `parents` argument to obsstore.create

login
register
mail settings
Submitter Pierre-Yves David
Date Aug. 19, 2014, 10:46 p.m.
Message ID <33cd02c4abe039f111f8.1408488401@marginatus.alto.octopoid.net>
Download mbox | patch
Permalink /patch/5518/
State Accepted
Headers show

Comments

Pierre-Yves David - Aug. 19, 2014, 10:46 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1408403549 25200
#      Mon Aug 18 16:12:29 2014 -0700
# Node ID 33cd02c4abe039f111f83e5a8a30189a8539b1a3
# Parent  2b67de4393d277280d3483381ea4f1a7855b4bae
obsstore: add a `parents` argument to obsstore.create

We needs a way to pass the information to the function. Some guru told me that
what's arguments are made for.

Patch

diff --git a/mercurial/obsolete.py b/mercurial/obsolete.py
--- a/mercurial/obsolete.py
+++ b/mercurial/obsolete.py
@@ -270,12 +270,12 @@  class obsstore(object):
         return len(self._all)
 
     def __nonzero__(self):
         return bool(self._all)
 
-    def create(self, transaction, prec, succs=(), flag=0, date=None,
-               metadata=None):
+    def create(self, transaction, prec, succs=(), flag=0, parents=None,
+               date=None, metadata=None):
         """obsolete: add a new obsolete marker
 
         * ensuring it is hashable
         * check mandatory metadata
         * encode metadata
@@ -300,11 +300,11 @@  class obsstore(object):
             if len(succ) != 20:
                 raise ValueError(succ)
         if prec in succs:
             raise ValueError(_('in-marker cycle with %s') % node.hex(prec))
         marker = (str(prec), tuple(succs), int(flag), encodemeta(metadata),
-                  date, None)
+                  date, parents)
         return bool(self.add(transaction, [marker]))
 
     def add(self, transaction, markers):
         """Add new markers to the store