Patchwork exchange: remove duplicated addition to pushop.stepdone

login
register
mail settings
Submitter Pierre-Yves David
Date Aug. 16, 2014, 2:21 a.m.
Message ID <06aaeda2eb3038c67b6e.1408155673@marginatus.alto.octopoid.net>
Download mbox | patch
Permalink /patch/5451/
State Accepted
Headers show

Comments

Pierre-Yves David - Aug. 16, 2014, 2:21 a.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1408155501 25200
#      Fri Aug 15 19:18:21 2014 -0700
# Node ID 06aaeda2eb3038c67b6ea6c32cfb13ca9e532844
# Parent  8dda6f6ff564d8fe6ac7b8ce4c74eb9bfb5de14a
exchange: remove duplicated addition to pushop.stepdone

Not sure how it get there but it is useless.
Matt Mackall - Aug. 18, 2014, 5:43 p.m.
On Fri, 2014-08-15 at 19:21 -0700, Pierre-Yves David wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@fb.com>
> # Date 1408155501 25200
> #      Fri Aug 15 19:18:21 2014 -0700
> # Node ID 06aaeda2eb3038c67b6ea6c32cfb13ca9e532844
> # Parent  8dda6f6ff564d8fe6ac7b8ce4c74eb9bfb5de14a
> exchange: remove duplicated addition to pushop.stepdone

Queued for default, thanks.

Patch

diff --git a/mercurial/exchange.py b/mercurial/exchange.py
--- a/mercurial/exchange.py
+++ b/mercurial/exchange.py
@@ -351,11 +351,10 @@  def _pushb2ctx(pushop, bundler):
     """
     if 'changesets' in pushop.stepsdone:
         return
     pushop.stepsdone.add('changesets')
     # Send known heads to the server for race detection.
-    pushop.stepsdone.add('changesets')
     if not _pushcheckoutgoing(pushop):
         return
     pushop.repo.prepushoutgoinghooks(pushop.repo,
                                      pushop.remote,
                                      pushop.outgoing)