From patchwork Fri Aug 15 14:21:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [7, of, 7] cleanup: name unused variables using convention of leading _ From: Mads Kiilerich X-Patchwork-Id: 5429 Message-Id: <8c720044deccfa025baf.1408112483@mk-desktop> To: mercurial-devel@selenic.com Date: Fri, 15 Aug 2014 16:21:23 +0200 # HG changeset patch # User Mads Kiilerich # Date 1408070266 -7200 # Fri Aug 15 04:37:46 2014 +0200 # Node ID 8c720044deccfa025baf6f0f0192a23eb91e6143 # Parent cd9f59027952dd5513c4e45dc4e50a37894a7088 cleanup: name unused variables using convention of leading _ This helps checker tools ... and readability for those who knows and follows the convention. diff --git a/mercurial/transaction.py b/mercurial/transaction.py --- a/mercurial/transaction.py +++ b/mercurial/transaction.py @@ -24,7 +24,7 @@ def active(func): return _active def _playback(journal, report, opener, entries, backupentries, unlink=True): - for f, o, ignore in entries: + for f, o, _ignore in entries: if o or not unlink: try: fp = opener(f, 'a') @@ -41,7 +41,7 @@ def _playback(journal, report, opener, e raise backupfiles = [] - for f, b, ignore in backupentries: + for f, b, _ignore in backupentries: filepath = opener.join(f) backuppath = opener.join(b) try: @@ -265,7 +265,7 @@ class transaction(object): self.opener.unlink(self.journal) if self.opener.isfile(self.backupjournal): self.opener.unlink(self.backupjournal) - for f, b, _ignore in self.backupentries: + for _f, b, _ignore in self.backupentries: self.opener.unlink(b) self.backupentries = [] self.journal = None