Patchwork [1,of,2] test-alias: add some tests to ensure we aren't double-substituting

login
register
mail settings
Submitter Siddharth Agarwal
Date Aug. 14, 2014, 6:54 a.m.
Message ID <c3fbbb727b54c25c93ef.1407999276@devbig136.prn2.facebook.com>
Download mbox | patch
Permalink /patch/5393/
State Accepted
Headers show

Comments

Siddharth Agarwal - Aug. 14, 2014, 6:54 a.m.
# HG changeset patch
# User Siddharth Agarwal <sid0@fb.com>
# Date 1407994629 25200
#      Wed Aug 13 22:37:09 2014 -0700
# Node ID c3fbbb727b54c25c93ef64a7353e62503e0fa441
# Parent  44d6818b9cd9db2c209a09dd162ef2fd745271e8
test-alias: add some tests to ensure we aren't double-substituting

An earlier iteration of an upcoming patch caused inadvertent
double substitution. Ensure we have test coverage for this.

Patch

diff --git a/tests/test-alias.t b/tests/test-alias.t
--- a/tests/test-alias.t
+++ b/tests/test-alias.t
@@ -229,6 +229,10 @@ 
   foo
   $ hg echoall 'test $2' foo
   test $2 foo
+  $ hg echoall 'test $@' foo '$@'
+  test $@ foo $@
+  $ hg echoall 'test "$@"' foo '"$@"'
+  test "$@" foo "$@"
   $ hg echo1 foo bar baz
   foo
   $ hg echo2 foo bar baz