Patchwork [3,of,6,stable] largefiles: drop setting lfstatus in overridelog (issue4334)

login
register
mail settings
Submitter Siddharth Agarwal
Date Aug. 13, 2014, 11:05 p.m.
Message ID <f8b7102e2de614132fd1.1407971122@devbig136.prn2.facebook.com>
Download mbox | patch
Permalink /patch/5383/
State Accepted
Headers show

Comments

Siddharth Agarwal - Aug. 13, 2014, 11:05 p.m.
# HG changeset patch
# User Siddharth Agarwal <sid0@fb.com>
# Date 1407968030 25200
#      Wed Aug 13 15:13:50 2014 -0700
# Branch stable
# Node ID f8b7102e2de614132fd1ff5291cd2b33a795b9c7
# Parent  2d22504013642e95deb73811347276b11aefa469
largefiles: drop setting lfstatus in overridelog (issue4334)

lfstatus should only be True for operations where we want standins to be
printed out. We explicitly do not want that for historical operations like log.
Other historical operations like hg diff -r A -r B don't print out standins
either.

This is required to fix issue4334, but doesn't fix anything by itself. That's
why there aren't any tests accompanying this patch.

Patch

diff --git a/hgext/largefiles/overrides.py b/hgext/largefiles/overrides.py
--- a/hgext/largefiles/overrides.py
+++ b/hgext/largefiles/overrides.py
@@ -301,10 +301,8 @@ 
 
     oldmatchandpats = installmatchandpatsfn(overridematchandpats)
     try:
-        repo.lfstatus = True
         return orig(ui, repo, *pats, **opts)
     finally:
-        repo.lfstatus = False
         restorematchandpatsfn()
 
 def overrideverify(orig, ui, repo, *pats, **opts):