Patchwork [2,of,4] test-revert: drop useless comment

login
register
mail settings
Submitter Pierre-Yves David
Date Aug. 8, 2014, 10:27 p.m.
Message ID <ef62b424770799e3e9e9.1407536876@marginatus.alto.octopoid.net>
Download mbox | patch
Permalink /patch/5330/
State Accepted
Headers show

Comments

Pierre-Yves David - Aug. 8, 2014, 10:27 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1403708361 -3600
#      Wed Jun 25 15:59:21 2014 +0100
# Node ID ef62b424770799e3e9e970f7e0ef4a3493f72211
# Parent  2e2109ca6773462a30ca01125153ad4e1d9189b4
test-revert: drop useless comment

There is multiple comments explaining the expected output of commands. This is
old relic of pre-unified test era. We remove them for uselessness.
Matt Mackall - Aug. 11, 2014, 3:10 p.m.
On Fri, 2014-08-08 at 15:27 -0700, Pierre-Yves David wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@fb.com>
> # Date 1403708361 -3600
> #      Wed Jun 25 15:59:21 2014 +0100
> # Node ID ef62b424770799e3e9e970f7e0ef4a3493f72211
> # Parent  2e2109ca6773462a30ca01125153ad4e1d9189b4
> test-revert: drop useless comment

> -should show b unknown
> -
> -  $ hg status
> -  ? b

Not a comment (x5).

Patch

diff --git a/tests/test-revert.t b/tests/test-revert.t
--- a/tests/test-revert.t
+++ b/tests/test-revert.t
@@ -16,93 +16,49 @@  nothing changed
 
 Introduce some changes and revert them
 --------------------------------------
 
   $ echo 123 > b
-
-should show b unknown
-
-  $ hg status
-  ? b
   $ echo 12 > c
-
-should show b unknown and c modified
-
-  $ hg status
-  M c
-  ? b
   $ hg add b
-
-should show b added and c modified
-
-  $ hg status
-  M c
-  A b
   $ hg rm a
 
-should show a removed, b added and c modified
-
   $ hg status
   M c
   A b
   R a
 
 revert removal of a file
 
   $ hg revert a
-
-should show b added, copy saved, and c modified
-
   $ hg status
   M c
   A b
 
 revert addition of a file
 
   $ hg revert b
-
-should show b unknown, and c modified
-
   $ hg status
   M c
   ? b
 
 revert modification of a file (--no-backup)
 
   $ hg revert --no-backup c
-
-should show unknown: b
-
   $ hg status
   ? b
 
 
 revert deletion (! status) of a added file
 ------------------------------------------
 
   $ hg add b
-
-should show b added
-
-  $ hg status b
-  A b
   $ rm b
-
-should show b deleted
-
   $ hg status b
   ! b
   $ hg revert -v b
   forgetting b
-
-should not find b
-
-  $ hg status b
-  b: * (glob)
-
-should show a c e
-
   $ ls
   a
   c
   e
 
@@ -186,24 +142,20 @@  revert of exec bit
 #if execbit
   $ chmod +x c
   $ hg revert --all
   reverting c
 
-should print non-executable
-
   $ test -x c || echo non-executable
   non-executable
 
   $ chmod +x c
   $ hg commit -m exe
 
   $ chmod -x c
   $ hg revert --all
   reverting c
 
-should print executable
-
   $ test -x c && echo executable
   executable
 #endif
 
   $ cd ..