D12608: node: manually implement Debug

Submitter	phabricator
Date	May 5, 2022, 6:51 p.m.
Message ID	<differential-rev-PHID-DREV-l4w4urdjxx3tqu3zrbyl-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/50960/
State	New
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Thu, 5 May 2022 18:51:44 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "durin42 (Augie Fackler)" <phabricator@mercurial-scm.org> Subject: D12608: node: manually implement Debug Message-ID: <differential-rev-PHID-DREV-l4w4urdjxx3tqu3zrbyl-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-l4w4urdjxx3tqu3zrbyl Thread-Index: YTQwNDJlMjhiYWRkZjE0Y2YyMTUwZTM5ZDMz MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "durin42 \(Augie Fackler\)" <phabricator+D12608+public+3f0e9a8ce858051b@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - May 5, 2022, 6:51 p.m.

durin42 created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  I got too irritated today with the default Debug implementation of
  hg::revlog::Node while playing with a new parser. This isn't quite
  what I wanted, but it wasn't much code and it at least gives you
  output that's easy to visually compare to a node.hex()ed identifier
  from the Python side of things.
  
  Sadly, this doesn't influence the output in lldb or the VSCode
  debugger extension that uses lldb under the covers, but it at least
  means debug prints are a little more useful.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D12608

AFFECTED FILES
  rust/hg-core/src/revlog/node.rs

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/rust/hg-core/src/revlog/node.rs b/rust/hg-core/src/revlog/node.rs
--- a/rust/hg-core/src/revlog/node.rs
+++ b/rust/hg-core/src/revlog/node.rs
@@ -53,12 +53,21 @@ 
 /// the size or return an error at runtime.
 ///
 /// [`nybbles_len`]: #method.nybbles_len
-#[derive(Copy, Clone, Debug, PartialEq, BytesCast, derive_more::From)]
+#[derive(Copy, Clone, PartialEq, BytesCast, derive_more::From)]
 #[repr(transparent)]
 pub struct Node {
     data: NodeData,
 }
 
+impl fmt::Debug for Node {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        let n = format!("{:x?}", self.data);
+        // We're using debug_tuple because it makes the output a little
+        // more compact without losing data.
+        f.debug_tuple("Node").field(&n).finish()
+    }
+}
+
 /// The node value for NULL_REVISION
 pub const NULL_NODE: Node = Node {
     data: [0; NODE_BYTES_LENGTH],

Patchwork D12608: node: manually implement Debug

Comments

Patch