D12301: windows: remove conditional for Python 3

Submitter	phabricator
Date	March 2, 2022, 11:31 p.m.
Message ID	<differential-rev-PHID-DREV-3jjytw5z4ibwsui3k6bo-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/50639/
State	New
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Wed, 2 Mar 2022 23:31:19 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "indygreg (Gregory Szorc)" <phabricator@mercurial-scm.org> Subject: D12301: windows: remove conditional for Python 3 Message-ID: <differential-rev-PHID-DREV-3jjytw5z4ibwsui3k6bo-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-3jjytw5z4ibwsui3k6bo Thread-Index: YWQ0ZjlmMGFlNWNkOGZlZjM0ODc3NTMwZGEy MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "indygreg \(Gregory Szorc\)" <phabricator+D12301+public+d09bfaca0300e5be@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - March 2, 2022, 11:31 p.m.

indygreg created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D12301

AFFECTED FILES
  mercurial/windows.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/windows.py b/mercurial/windows.py
--- a/mercurial/windows.py
+++ b/mercurial/windows.py
@@ -162,8 +162,7 @@ 
 
         # PyFile_FromFd() ignores the name, and seems to report fp.name as the
         # underlying file descriptor.
-        if pycompat.ispy3:
-            fp = fdproxy(name, fp)
+        fp = fdproxy(name, fp)
 
         # The position when opening in append mode is implementation defined, so
         # make it consistent with other platforms, which position at EOF.

Patchwork D12301: windows: remove conditional for Python 3

Comments

Patch