D12291: formatter: remove conditional assert

Submitter	phabricator
Date	March 2, 2022, 11:30 p.m.
Message ID	<differential-rev-PHID-DREV-63f4pzke4jbh5v63i36h-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/50632/
State	New
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Wed, 2 Mar 2022 23:30:41 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "indygreg (Gregory Szorc)" <phabricator@mercurial-scm.org> Subject: D12291: formatter: remove conditional assert Message-ID: <differential-rev-PHID-DREV-63f4pzke4jbh5v63i36h-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-63f4pzke4jbh5v63i36h Thread-Index: OWVkNzU2MTU1MGYwMDZkYjQxYmE3OGNlZTVi MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "indygreg \(Gregory Szorc\)" <phabricator+D12291+public+24e2af417b6b1a5e@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - March 2, 2022, 11:30 p.m.

indygreg created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  We always run on Python 3 now.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D12291

AFFECTED FILES
  mercurial/formatter.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/formatter.py b/mercurial/formatter.py
--- a/mercurial/formatter.py
+++ b/mercurial/formatter.py
@@ -558,8 +558,7 @@ 
 
 
 def literal_templatespec(tmpl):
-    if pycompat.ispy3:
-        assert not isinstance(tmpl, str), b'tmpl must not be a str'
+    assert not isinstance(tmpl, str), b'tmpl must not be a str'
     return templatespec(b'', tmpl, None)

Patchwork D12291: formatter: remove conditional assert

Comments

Patch