Patchwork [Bug,6646] New: python 3.10 compatibility warnings break tests

login
register
mail settings
Submitter mercurial-bugs@mercurial-scm.org
Date Feb. 15, 2022, 10:18 a.m.
Message ID <bug-6646-285@https.bz.mercurial-scm.org/>
Download mbox | patch
Permalink /patch/50518/
State New
Headers show

Comments

mercurial-bugs@mercurial-scm.org - Feb. 15, 2022, 10:18 a.m.
https://bz.mercurial-scm.org/show_bug.cgi?id=6646

            Bug ID: 6646
           Summary: python 3.10 compatibility warnings break tests
           Product: Mercurial
           Version: 6.0.2
          Hardware: All
                OS: NetBSD
            Status: UNCONFIRMED
          Severity: bug
          Priority: wish
         Component: Mercurial
          Assignee: bugzilla@mercurial-scm.org
          Reporter: tk@giga.or.at
                CC: mercurial-devel@mercurial-scm.org
    Python Version: ---

Zeroconf deprecation warnings in 3.10 break some tests.

   $ HGRCSKIPREPO=1 hg paths --config extensions.zeroconf=                      

ERROR: test-hgrc.t output changed                                               


There is another warning text change which I suspect is also python
3.10-specific:

--- /scratch/devel/py-mercurial/work/mercurial-6.0.2/tests/test-parseindex.t    
+++
/scratch/devel/py-mercurial/work/mercurial-6.0.2/tests/test-parseindex.t.err    
@@ -113,7 +113,7 @@                                                             
   10000: head out of range                                                     
   -2: head out of range                                                        
   -10000: head out of range                                                    
-  None: an integer is required( .got type NoneType.)? (re)                     
+  None: 'NoneType' object cannot be interpreted as an integer                  
   good roots:                                                                  
   0: [0]                                                                       
   1: [1]                                                                       
@@ -124,7 +124,7 @@                                                             
   -2: []                                                                       
   -10000: []                                                                 
   bad roots:                                                                   
-  None: an integer is required( .got type NoneType.)? (re)                     
+  None: 'NoneType' object cannot be interpreted as an integer                  

   $ cd ..                                                                      


ERROR: test-parseindex.t output changed

Patch

--- /scratch/devel/py-mercurial/work/mercurial-6.0.2/tests/test-paths.t         
+++ /scratch/devel/py-mercurial/work/mercurial-6.0.2/tests/test-paths.t.err     
@@ -146,6 +146,8 @@                                                              

 #if no-pyoxidizer                                                              
   $ hg paths --config extensions.zeroconf=                                     
+  /tmp/hgtests.2d_twpz0/install/lib/python/hgext/zeroconf/Zeroconf.py:1464:
DeprecationWarning: notifyAll() is deprecated, use notify_all() instead         
+    self.condition.notifyAll()                                                 
   dupe = $TESTTMP/b#tip                                                        
   dupe:pushurl = https://example.com/dupe                                      
   expand = $TESTTMP/a/$SOMETHING/bar                                           

ERROR: test-paths.t output changed                                              
!.............................s.....s..s......s......s.......................s........sss............ssssss..... 
--- /scratch/devel/py-mercurial/work/mercurial-6.0.2/tests/test-hgrc.t          
+++ /scratch/devel/py-mercurial/work/mercurial-6.0.2/tests/test-hgrc.t.err      
@@ -310,6 +310,8 @@                                                              

 #if no-pyoxidizer                                                              
   $ HGRCSKIPREPO=1 hg paths --config extensions.zeroconf=                      
+  /tmp/hgtests.2d_twpz0/install/lib/python/hgext/zeroconf/Zeroconf.py:1464:
DeprecationWarning: notifyAll() is deprecated, use notify_all() instead         
+    self.condition.notifyAll()                                                 
   foo = $TESTTMP/bar                                                           
 #else