Patchwork D12176: revlog: do not compute node location by hand in index_invalidate_added

login
register
mail settings
Submitter phabricator
Date Feb. 14, 2022, 6:06 p.m.
Message ID <differential-rev-PHID-DREV-wqfhdm433xezdhz2p2on-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/50511/
State New
Headers show

Comments

phabricator - Feb. 14, 2022, 6:06 p.m.
pacien created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  The node is not guaranteed to be at the same location all the time (e.g:
  changelog v2), so let's use the official existing API to get that value.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D12176

AFFECTED FILES
  mercurial/cext/revlog.c

CHANGE DETAILS




To: pacien, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/cext/revlog.c b/mercurial/cext/revlog.c
--- a/mercurial/cext/revlog.c
+++ b/mercurial/cext/revlog.c
@@ -2734,8 +2734,10 @@ 
 	if (i < 0)
 		return;
 
-	for (i = start; i < len; i++)
-		nt_delete_node(&self->nt, index_deref(self, i) + 32);
+	for (i = start; i < len; i++) {
+		const char *node = index_node(self, i);
+		nt_delete_node(&self->nt, node);
+	}
 
 	self->new_length = start - self->length;
 }