Patchwork D12157: scmutil: obsrevs is already a frozenset

login
register
mail settings
Submitter phabricator
Date Feb. 9, 2022, 3:44 p.m.
Message ID <differential-rev-PHID-DREV-udbm5u56osfninyrnnl7-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/50492/
State New
Headers show

Comments

phabricator - Feb. 9, 2022, 3:44 p.m.
av6 created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D12157

AFFECTED FILES
  mercurial/scmutil.py

CHANGE DETAILS




To: av6, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py
--- a/mercurial/scmutil.py
+++ b/mercurial/scmutil.py
@@ -366,9 +366,7 @@ 
         obsrevs = obsolete.getrevs(repo, b'obsolete')
         if not cl.filteredrevs and not obsrevs:
             return None
-        # TODO: obsrevs should be a frozenset, but right now obsolete.getrevs()
-        # may return a set, which is not a hashable type.
-        key = (maxrev, hash(cl.filteredrevs), hash(frozenset(obsrevs)))
+        key = (maxrev, hash(cl.filteredrevs), hash(obsrevs))
     else:
         if not cl.filteredrevs:
             return None