Patchwork help: properly document the default pattern

login
register
mail settings
Submitter Jordi Gutiérrez Hermoso
Date Dec. 26, 2021, 6:46 p.m.
Message ID <e5b62cbab03e443841b2.1640544364@chloe>
Download mbox | patch
Permalink /patch/50280/
State New
Headers show

Comments

Jordi Gutiérrez Hermoso - Dec. 26, 2021, 6:46 p.m.
# HG changeset patch
# User Jordi Gutiérrez Hermoso <jordigh@octave.org>
# Date 1550269232 18000
#      Fri Feb 15 17:20:32 2019 -0500
# Node ID e5b62cbab03e443841b23a333aac035ad3987fbf
# Parent  d3ec8201610485fa8bfda40771869ae67bfc6404
help: properly document the default pattern

The default isn't to glob. It's relpath, which does no globbing at
all. Thus most commands and options like -X/-I and hg files require
`glob:` in front of them to actually do any globbing.

I think long ago the default was to glob, but that hasn't been true
for a long time.
Augie Fackler - Dec. 27, 2021, 8:22 p.m.
Queued, thanks.

> On Dec 26, 2021, at 1:46 PM, Jordi Gutiérrez Hermoso <jordigh@octave.org> wrote:
> 
> # HG changeset patch
> # User Jordi Gutiérrez Hermoso <jordigh@octave.org>
> # Date 1550269232 18000
> #      Fri Feb 15 17:20:32 2019 -0500
> # Node ID e5b62cbab03e443841b23a333aac035ad3987fbf
> # Parent  d3ec8201610485fa8bfda40771869ae67bfc6404
> help: properly document the default pattern
> 
> The default isn't to glob. It's relpath, which does no globbing at
> all. Thus most commands and options like -X/-I and hg files require
> `glob:` in front of them to actually do any globbing.
> 
> I think long ago the default was to glob, but that hasn't been true
> for a long time.
> 
> diff --git a/mercurial/helptext/patterns.txt b/mercurial/helptext/patterns.txt
> --- a/mercurial/helptext/patterns.txt
> +++ b/mercurial/helptext/patterns.txt
> @@ -1,8 +1,10 @@
> Mercurial accepts several notations for identifying one or more files
> at a time.
> 
> -By default, Mercurial treats filenames as shell-style extended glob
> -patterns.
> +By default, Mercurial treats filenames verbatim without pattern
> +matching, relative to the current working directory. Note that your
> +system shell might perform pattern matching of its own before passing
> +filenames into Mercurial.
> 
> Alternate pattern notations must be specified explicitly.
> 
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Patch

diff --git a/mercurial/helptext/patterns.txt b/mercurial/helptext/patterns.txt
--- a/mercurial/helptext/patterns.txt
+++ b/mercurial/helptext/patterns.txt
@@ -1,8 +1,10 @@ 
 Mercurial accepts several notations for identifying one or more files
 at a time.
 
-By default, Mercurial treats filenames as shell-style extended glob
-patterns.
+By default, Mercurial treats filenames verbatim without pattern
+matching, relative to the current working directory. Note that your
+system shell might perform pattern matching of its own before passing
+filenames into Mercurial.
 
 Alternate pattern notations must be specified explicitly.