Patchwork hg: remove reserved identifiers

login
register
mail settings
Submitter David Demelier
Date Oct. 21, 2021, 9:21 a.m.
Message ID <84d470049d323b8137cd.1634808093@alpine>
Download mbox | patch
Permalink /patch/50040/
State Accepted
Headers show

Comments

David Demelier - Oct. 21, 2021, 9:21 a.m.
# HG changeset patch
# User David Demelier <markand@malikania.fr>
# Date 1634808081 -7200
#      Thu Oct 21 11:21:21 2021 +0200
# Node ID 84d470049d323b8137cd6bbc68a521612fdebad9
# Parent  f7fd629ffb98d56e1023092e1210c4523f301f9b
hg: remove reserved identifiers

Per 7.1.3 paragraph, from C draft:

All identifiers that begin with an underscore and either an uppercase letter or
another underscore are always reserved for any use.
Yuya Nishihara - Oct. 21, 2021, 10:15 a.m.
On Thu, 21 Oct 2021 11:21:33 +0200, David Demelier wrote:
> # HG changeset patch
> # User David Demelier <markand@malikania.fr>
> # Date 1634808081 -7200
> #      Thu Oct 21 11:21:21 2021 +0200
> # Node ID 84d470049d323b8137cd6bbc68a521612fdebad9
> # Parent  f7fd629ffb98d56e1023092e1210c4523f301f9b
> hg: remove reserved identifiers

Queued, thanks.

Patch

diff -r f7fd629ffb98 -r 84d470049d32 mercurial/bdiff.h
--- a/mercurial/bdiff.h	Thu Oct 14 16:39:16 2021 +0200
+++ b/mercurial/bdiff.h	Thu Oct 21 11:21:21 2021 +0200
@@ -1,5 +1,5 @@ 
-#ifndef _HG_BDIFF_H_
-#define _HG_BDIFF_H_
+#ifndef HG_BDIFF_H
+#define HG_BDIFF_H
 
 #include "compat.h"
 
diff -r f7fd629ffb98 -r 84d470049d32 mercurial/bitmanipulation.h
--- a/mercurial/bitmanipulation.h	Thu Oct 14 16:39:16 2021 +0200
+++ b/mercurial/bitmanipulation.h	Thu Oct 21 11:21:21 2021 +0200
@@ -1,5 +1,5 @@ 
-#ifndef _HG_BITMANIPULATION_H_
-#define _HG_BITMANIPULATION_H_
+#ifndef HG_BITMANIPULATION_H
+#define HG_BITMANIPULATION_H
 
 #include <string.h>
 
diff -r f7fd629ffb98 -r 84d470049d32 mercurial/compat.h
--- a/mercurial/compat.h	Thu Oct 14 16:39:16 2021 +0200
+++ b/mercurial/compat.h	Thu Oct 21 11:21:21 2021 +0200
@@ -1,5 +1,5 @@ 
-#ifndef _HG_COMPAT_H_
-#define _HG_COMPAT_H_
+#ifndef HG_COMPAT_H
+#define HG_COMPAT_H
 
 #ifdef _WIN32
 #ifdef _MSC_VER
diff -r f7fd629ffb98 -r 84d470049d32 mercurial/mpatch.h
--- a/mercurial/mpatch.h	Thu Oct 14 16:39:16 2021 +0200
+++ b/mercurial/mpatch.h	Thu Oct 21 11:21:21 2021 +0200
@@ -1,5 +1,5 @@ 
-#ifndef _HG_MPATCH_H_
-#define _HG_MPATCH_H_
+#ifndef HG_MPATCH_H
+#define HG_MPATCH_H
 
 #define MPATCH_ERR_NO_MEM -3
 #define MPATCH_ERR_CANNOT_BE_DECODED -2