Patchwork D11623: dirstate-v2: Use "byte sequence" in docs

login
register
mail settings
Submitter phabricator
Date Oct. 11, 2021, 8:31 p.m.
Message ID <differential-rev-PHID-DREV-6cs67fjrrxijbjerjnwo-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/49947/
State Superseded
Headers show

Comments

phabricator - Oct. 11, 2021, 8:31 p.m.
SimonSapin created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  The patch originally sent as https://phab.mercurial-scm.org/D11546
  used "byte string" but that was changed during review to avoid suggesting
  Unicode or character encodings.
  
  However "byte range" sounds to be like a range of *indices* within a byte
  string/sequence elsewhere.
  
  This changes to "byte sequence". Python docs use "sequence" a lot when
  discussing the `bytes` type: https://docs.python.org/3/library/stdtypes.html

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D11623

AFFECTED FILES
  mercurial/helptext/internals/dirstate-v2.txt

CHANGE DETAILS




To: SimonSapin, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/helptext/internals/dirstate-v2.txt b/mercurial/helptext/internals/dirstate-v2.txt
--- a/mercurial/helptext/internals/dirstate-v2.txt
+++ b/mercurial/helptext/internals/dirstate-v2.txt
@@ -285,10 +285,10 @@ 
 
 This hash is defined as the SHA-1 of the concatenation (in sorted
 order) of the "expanded contents" of each "root" ignore file.
-(Note that computing this does not require actually concatenating byte ranges into
-contiguous memory.
-Instead a SHA-1 hasher object can be created and fed separate byte ranges one by
-one.)
+(Note that computing this does not require actually concatenating
+into a single contiguous byte sequence.
+Instead a SHA-1 hasher object can be created
+and fed separate chunks one by one.)
 
 The data file format
 --------------------
@@ -299,11 +299,12 @@ 
 The data file contains two types of data: paths and nodes.
 
 Paths and nodes can be organized in any order in the file, except that sibling
-nodes must be next to each other and sorted by their path. Contiguity lets
-the parent refer to them all by their count with a single pseudo-pointer,
-instead of storing one pseudo-pointer per child node. Sorting allows using
-binary seach to find a child node with a given name in `O(log(n))` byte ranges
-comparisons.
+nodes must be next to each other and sorted by their path.
+Contiguity lets the parent refer to them all
+by their count and a single pseudo-pointer,
+instead of storing one pseudo-pointer per child node.
+Sorting allows using binary seach to find a child node with a given name
+in `O(log(n))` byte sequence comparisons.
 
 The current implemention writes paths and child node before a given node
 for ease of figuring out the value of pseudo-pointers by the time the are to be